Date: Sat, 28 Oct 2006 22:10:12 -0700 From: "Matthew Jacob" <lydianconcepts@gmail.com> To: freebsd-scsi@freebsd.org Subject: Re: CAM_NEW_TRAN- kernel changes ready for review Message-ID: <7579f7fb0610282210p59de2123g379f0d4069bd1e42@mail.gmail.com> In-Reply-To: <7579f7fb0610281854l3ec600d7kf0a2cdf20fdcb838@mail.gmail.com> References: <7579f7fb0610281854l3ec600d7kf0a2cdf20fdcb838@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This has been updated after I found I'd forgotten to fill in a couple of items (*cough*). On 10/28/06, Matthew Jacob <lydianconcepts@gmail.com> wrote: > http://people.freebsd.org/~mjacob/DIFFS.CAM_NEW_TRAN_CODE > > This covers all the kernel changes. I did not do bug fixing or code > correction while I was at it (with a couple of obvious fixes that were > just glaringly wrong). So, if the > XPT_GET_TRAN_SETTINGS/XPT_SET_TRAN_SETTINGS code in each SIM was not > perfect before, it's still not perfect now. > > This did a LINT+CAM_NEW_TRAN_CODE compile and I'll do some actual h/w > checking too. > > There's a slightly narsty issue with camlib and camcontrol's usage of > XPT_GET_TRAN_SETTINGS- *it* doesn't know about this change. I'm of two > minds about this- whether to just live with the breakage (which will > mean old camcontrol and other users of camlib won't work quite right), > or to make the letdown somewhat gentler by doing a slight reorg of the > new tran_settings structure and the enum for 'type' so that > CAM_NEW_TRAN_CODE will just coincidentally end up with identical usage > to old binaries. > > If all who are interested could, please review this and send comments > back within a couple of days as I don't want this to stall (this is > also a window of time I have for working on this- partly for work in > doing Domain Validation, but also partly because one of my consulting > gigs collapsed and I have a couple of days spare while I'm ramping up > others). >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7579f7fb0610282210p59de2123g379f0d4069bd1e42>