Date: Wed, 22 Nov 2006 21:10:16 GMT From: Johann Kois <jkois@freebsd.org> To: freebsd-www@FreeBSD.org Subject: Re: www/105333: [PATCH] Base selection in events in libcommon.xsl does not work Message-ID: <200611222110.kAMLAGFB003382@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR www/105333; it has been noted by GNATS.
From: Johann Kois <jkois@freebsd.org>
To: bug-followup@freebsd.org,
cejkar@fit.vutbr.cz
Cc:
Subject: Re: www/105333: [PATCH] Base selection in events in libcommon.xsl does not work
Date: Wed, 22 Nov 2006 22:08:17 +0100
Although the patch provided in PR: www/105333
should fix the problem with the localized
versions of our website (you get an "error 404"
when clicking on a link in the events list)
this solution creates a new problem.
If a translated version of "events.xml" already
exists users will be pointed to the translated
version (even if this file is totally outdated
which is the case with the french version of
"events.xml" for example).
So I think it would be better not to translate
"events.xml" at all and to point users to the
english version of events.xml even from the
localized parts of our website with something
like the following:
--- libcommon.xsl Mon Nov 20 16:03:01 2006
+++ libcommon.xsl.new Wed Nov 22 21:20:54 2006
@@ -1083,8 +1083,7 @@
<a>
<xsl:attribute name="href">
<xsl:choose>
- <xsl:when test="$events.xml = 'none'">&enbase;/</xsl:when>
- <xsl:otherwise>&base;/</xsl:otherwise>
+ <xsl:when test="$events.xml =
$events.xml-master">&enbase;/</xsl:when>
</xsl:choose>
<xsl:text>events/#event:</xsl:text><xsl:value-of
select='@id' />
</xsl:attribute>
But as my knowledge on XML, XSL and so on is rather
limited and additionally my commit bit does not cover
this part of the source tree one of the other
doc/www-committers would have to take a look at this
problem/PR.
J. Kois
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611222110.kAMLAGFB003382>