Date: Sun, 24 Apr 2016 19:01:02 +0200 From: Jan Beich <jbeich@vfemail.net> To: Jens Schweikhardt <schweikh@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298537 - head/etc/rc.d Message-ID: <oa8z-54c1-wny@vfemail.net> In-Reply-To: <201604241053.u3OAr0bn072180@repo.freebsd.org> (Jens Schweikhardt's message of "Sun, 24 Apr 2016 10:53:00 %2B0000 (UTC)") References: <201604241053.u3OAr0bn072180@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Jens Schweikhardt <schweikh@FreeBSD.org> writes:
> - parenthesize the "case" string for symmetry and improved
> search for matching paren (e.g. with vi's %)
[...]
> case "${state}" in
> - [oO][nN])
> + ([oO][nN])
> swapon /dev/zvol/${name}
> ;;
For style consistency is more important. Why this case is special unlike
the rest of rc.d/* or rc.subr ?
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJXHPvPXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bfEcIAIbtP/5UT5IwJsFrq9XnnFZg
tLIxr92wn0sYRP5v2a8tg9dvqvuk3g1LH/Fz4MDGP7MeTSbxcG7z1PkZor3uWkTR
qSibgtFNFeO9LjZYioBYcAYfaI5fA4NHT+dX6/LCdG5XH3EtJaOwZnf+TNB/3UQv
9UrqQYKT7LGL6t5XS21WWQ7XjfxV4qMS/URfGDSxFa1d5v4wergV8eOUgxd6w2FQ
WEpplEhtAGDWsdCLQxbPf3itUGuqweB5Fua0HKeT2ruzmGmzSG8PtHzZCqwU5ENW
2coPoqaR12Tg+QZgDk7PUHzOInm7sxBYCCz3cPQRP6kvZr0tBqtWcoC4PFmZl44=
=M9FN
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?oa8z-54c1-wny>