Date: Tue, 26 Jan 2016 14:58:00 -0800 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Luigi Rizzo <luigi@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r294855 - head/sys/netpfil/ipfw Message-ID: <20160126225800.GV6885@FreeBSD.org> In-Reply-To: <201601262245.u0QMj5Pi095914@repo.freebsd.org> References: <201601262245.u0QMj5Pi095914@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Luigi,
On Tue, Jan 26, 2016 at 10:45:05PM +0000, Luigi Rizzo wrote:
L> Modified: head/sys/netpfil/ipfw/dn_heap.c
L> ==============================================================================
L> --- head/sys/netpfil/ipfw/dn_heap.c Tue Jan 26 22:32:58 2016 (r294854)
L> +++ head/sys/netpfil/ipfw/dn_heap.c Tue Jan 26 22:45:05 2016 (r294855)
L> @@ -81,7 +81,7 @@ heap_resize(struct dn_heap *h, unsigned
L> {
L> struct dn_heap_entry *p;
L>
L> - if (h->size >= new_size ) /* have enough room */
L> + if ((unsigned int)h->size >= new_size ) /* have enough room */
L> return 0;
L> #if 1 /* round to the next power of 2 */
L> new_size |= new_size >> 1;
L> @@ -419,6 +419,8 @@ dn_ht_init(struct dn_ht *ht, int buckets
L> static int
L> do_del(void *obj, void *arg)
L> {
L> + (void)obj;
L> + (void)arg;
L> return DNHT_SCAN_DEL;
L> }
Are there any benefits of this syntax comparing to __unused macro
that expands to proper attribute? The latter syntax is used in
FreeBSD more often.
--
Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160126225800.GV6885>