Date: Wed, 27 Mar 2002 16:51:51 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: current@FreeBSD.org, Takahashi Yoshihiro <nyan@FreeBSD.org>, Makoto Matsushita <matusita@jp.FreeBSD.org> Subject: Re: cvs commit: src/usr.sbin/sysinstall Makefile Message-ID: <XFMail.20020327165151.jhb@FreeBSD.org> In-Reply-To: <20020327201914.GA52094@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27-Mar-2002 Ruslan Ermilov wrote:
> On Fri, Mar 15, 2002 at 10:34:26AM -0500, John Baldwin wrote:
>>
>> On 15-Mar-2002 Ruslan Ermilov wrote:
>> > ru 2002/03/15 03:27:47 PST
>> >
>> > Modified files:
>> > usr.sbin/sysinstall Makefile
>> > Log:
>> > Embed boot images built as part of buildworld rather than the
>> > installed ones under /boot (which we may not even have in the
>> > case of a cross build).
>>
>> Cool.
>>
>> > This introduced chicken and egg problem - we need boot images
>> > early in the "depend" stage but they have not yet been built.
>> > Work around this by excluding the generated makeboot.c source
>> > from the "depend" list; it's okay because we hardcode all its
>> > dependencies explicitly. We actually lose the dependency bit
>> > on <sys/types.h> but it's probably okay too as the only thing
>> > we use is the u_char datatype and this is unlikely to change.
>> > After all, it's normal for sloppy cleaning to cause problems.
>> >
>> > beast.FreeBSD.org running 5.0-CURRENT alpha has been able to
>> > cross build i386 world with this patch.
>> >
>> > Prodded by: gallatin
>>
>> Thanks for fixing this. Long term, I would like someone to fix
>> sysinstall so it reads these files out of /boot like we do for
>> boot{1,2} instead of hardcoding them into the binary. Junior
>> Sysinstall Hacker task I suppose. :)
>>
> Here's the patch. Please review.
Looks good to me assuming you've tested it. :)
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020327165151.jhb>