Date: Tue, 5 Nov 2013 19:17:52 -0500 From: Julio Merino <julio@meroh.net> To: freebsd-testing@freebsd.org Cc: Rui Paulo <rpaulo@fnop.net> Subject: Fixing the build with TESTS Message-ID: <CADyfeQW4GwhKgg4P8OWELnGWvDO8mvSjjo7Og3WMk2uxAGBGoA@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
--001a113490fac4fa2804ea7715a0 Content-Type: text/plain; charset=ISO-8859-1 Hello, The previous changes to enable the installation of tests broke the build and is the reason why Rui had to default the TESTS knob to 'no'. The reason for the breakage is the following: When buildworld starts by building the basic "bootstrap" libraries, it does a "make all" within various lib/* directories, including libcrypt. libcrypt had tests added to it, which means that "make all" recursed into the tests directory and attempted to build them. But, at that point, the atf libraries had not yet been built. I did not encounter this issue because I'm running builds with MK_CLEAN=no (yup, lesson learned). I think it's wrong for this stage of buildworld to attempt building tests at all. atf is just one of the many dependencies we'd encounter, and we should not try to build all dependencies upfront... because we cannot. (Just imagine when libc starts getting tests.) The fix-build-bootstrap.patch attached attempts to correct this by explicitly disabling the build of any tests during the initial build of the bootstrap components. I'm not sure this patch is nice enough, although it follows the style of various other related knobs; if you have better ideas, please share. Additionally, we will encounter similar issues once we have tests that use C++ (which we will, if only because of libatf-c++'s tests), so we should also do what fix-build-atf-cxx.patch proposes. Thoughts? Thanks, -- Julio Merino / @jmmv --001a113490fac4fa2804ea7715a0 Content-Type: application/octet-stream; name="fix-build-atf-cxx.patch" Content-Disposition: attachment; filename="fix-build-atf-cxx.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnnpmnyh0 QWRkIGxpYmF0Zi1jKysgdG8gdGhlIHByZWJ1aWxkIGxpYnMuCgpTb21lIHRlc3RzIG1heSByZXF1 aXJlIEMrKyBzbyB3ZSBtdXN0IGVuc3VyZSB0aGlzIGxpYnJhcnkgZXhpc3RzIGFzIHBhcnQKb2Yg dGhlIGJvb3RzdHJhcCBwcm9jZXNzIG9yIGVsc2UgdGhleSB3aWxsIGZhaWwgdG8gYnVpbGQuCgpJ bmRleDogc3JjL01ha2VmaWxlLmluYzEKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3JjLm9yaWcvTWFrZWZpbGUu aW5jMQorKysgc3JjL01ha2VmaWxlLmluYzEKQEAgLTE0NjIsNiArMTQ2Miw3IEBAIF9wcmVidWls ZF9saWJzPQkke19rZXJiZXJvczVfbGliX2xpYmFzbjEKIAkJJHtfa2VyYmVyb3M1X2xpYl9saWJy b2tlbn0gXAogCQkke19rZXJiZXJvczVfbGliX2xpYndpbmR9IFwKIAkJJHtfbGliX2F0Zl9saWJh dGZfY30gXAorCQkke19saWJfYXRmX2xpYmF0Zl9jeHh9IFwKIAkJbGliL2xpYmJ6MiAke19saWJj b21fZXJyfSBsaWIvbGliY3J5cHQgXAogCQlsaWIvbGliZWxmIGxpYi9saWJleHBhdCBcCiAJCSR7 X2xpYl9saWJnc3NhcGl9ICR7X2xpYl9saWJpcHh9IFwKQEAgLTE0NzcsNiArMTQ3OCw3IEBAIF9w cmVidWlsZF9saWJzPQkke19rZXJiZXJvczVfbGliX2xpYmFzbjEKIAogLmlmICR7TUtfQVRGfSAh PSAibm8iCiBfbGliX2F0Zl9saWJhdGZfYz0JbGliL2F0Zi9saWJhdGYtYworX2xpYl9hdGZfbGli YXRmX2N4eD0JbGliL2F0Zi9saWJhdGYtYysrCiAuZW5kaWYKIAogLmlmICR7TUtfTElCVEhSfSAh PSAibm8iCg== --001a113490fac4fa2804ea7715a0 Content-Type: application/octet-stream; name="fix-build-bootstrap.patch" Content-Disposition: attachment; filename="fix-build-bootstrap.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnnpmnzo1 Rml4IGNsZWFuIGJ1aWxkcyB3aGVuIFdJVEhfVEVTVFMgaXMgZW5hYmxlZC4KClRoZSBhZGRpdGlv biBvZiB0aGUgVEVTVFMga25vYiBhbmQgaXRzIGVuYWJsaW5nIG9mIHRoZSBidWlsZCBvZiB0ZXN0 cyBpbgpsaWIvbGliY3J5cHQvdGVzdHMvIGJyb2tlIHRoZSBidWlsZC4gIFRoZSByZWFzb24gaXMg dGhhdCB3ZSBjYW5ub3QgZGVzY2VuZAppbnRvIHRlc3RzLyBzdWJkaXJlY3RvcmllcyB1bnRpbCBh bGwgcHJlcmVxdWlzaXRlcyBoYXZlIGJlZW4gYnVpbHQsIHdoaWNoCmluIHRoZSBjYXNlIG9mIHRl c3RzIG1heSBiZSAiYSBsb3Qgb2YgdGhpbmdzIiAobGliYXRmLWMgaW4gdGhpcyBjYXNlKS4KCkVu c3VyZSB0aGF0IHdlIGRvIG5vdCB3YWxrIHRlc3RzLyBkaXJlY3RvcmllcyBkdXJpbmcgdGhlIGJv b3RzdHJhcHBpbmcgb2YKdGhlIGxpYnJhcmllcyBhcyBwYXJ0IG9mIGJ1aWxkd29ybGQuCgpJbmRl eDogc3JjL01ha2VmaWxlLmluYzEKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3JjLm9yaWcvTWFrZWZpbGUuaW5j MQorKysgc3JjL01ha2VmaWxlLmluYzEKQEAgLTE1ODUsMTAgKzE1ODUsMTIgQEAgJHtfbGlifV9f UEw6IC5QSE9OWSAuTUFLRQogLmlmIGV4aXN0cygkey5DVVJESVJ9LyR7X2xpYn0pCiAJJHtfK199 QCR7RUNIT0RJUn0gIj09PT4gJHtfbGlifSAob2JqLGRlcGVuZCxhbGwsaW5zdGFsbCkiOyBcCiAJ CWNkICR7LkNVUkRJUn0vJHtfbGlifSAmJiBcCi0JCSR7TUFLRX0gRElSUFJGWD0ke19saWJ9LyBv YmogJiYgXAotCQkke01BS0V9IERJUlBSRlg9JHtfbGlifS8gZGVwZW5kICYmIFwKLQkJJHtNQUtF fSAtRE5PX1BST0ZJTEUgLUROT19QSUMgRElSUFJGWD0ke19saWJ9LyBhbGwgJiYgXAotCQkke01B S0V9IC1ETk9fUFJPRklMRSAtRE5PX1BJQyBESVJQUkZYPSR7X2xpYn0vIGluc3RhbGwKKwkJJHtN QUtFfSBESVJQUkZYPSR7X2xpYn0vIC1EX05PX1RFU1RTX1lFVCBvYmogJiYgXAorCQkke01BS0V9 IERJUlBSRlg9JHtfbGlifS8gLURfTk9fVEVTVFNfWUVUIGRlcGVuZCAmJiBcCisJCSR7TUFLRX0g RElSUFJGWD0ke19saWJ9LyAtRF9OT19URVNUU19ZRVQgLUROT19QUk9GSUxFIFwKKwkJICAgIC1E Tk9fUElDIGFsbCAmJiBcCisJCSR7TUFLRX0gRElSUFJGWD0ke19saWJ9LyAtRF9OT19URVNUU19Z RVQgLUROT19QUk9GSUxFIFwKKwkJICAgIC1ETk9fUElDIGluc3RhbGwKIC5lbmRpZgogLmVuZGZv cgogCkBAIC0xNTk3LDEwICsxNTk5LDEwIEBAICR7X2xpYn1fX0w6IC5QSE9OWSAuTUFLRQogLmlm IGV4aXN0cygkey5DVVJESVJ9LyR7X2xpYn0pCiAJJHtfK199QCR7RUNIT0RJUn0gIj09PT4gJHtf bGlifSAob2JqLGRlcGVuZCxhbGwsaW5zdGFsbCkiOyBcCiAJCWNkICR7LkNVUkRJUn0vJHtfbGli fSAmJiBcCi0JCSR7TUFLRX0gRElSUFJGWD0ke19saWJ9LyBvYmogJiYgXAotCQkke01BS0V9IERJ UlBSRlg9JHtfbGlifS8gZGVwZW5kICYmIFwKLQkJJHtNQUtFfSBESVJQUkZYPSR7X2xpYn0vIGFs bCAmJiBcCi0JCSR7TUFLRX0gRElSUFJGWD0ke19saWJ9LyBpbnN0YWxsCisJCSR7TUFLRX0gRElS UFJGWD0ke19saWJ9LyAtRF9OT19URVNUU19ZRVQgb2JqICYmIFwKKwkJJHtNQUtFfSBESVJQUkZY PSR7X2xpYn0vIC1EX05PX1RFU1RTX1lFVCBkZXBlbmQgJiYgXAorCQkke01BS0V9IERJUlBSRlg9 JHtfbGlifS8gLURfTk9fVEVTVFNfWUVUIGFsbCAmJiBcCisJCSR7TUFLRX0gRElSUFJGWD0ke19s aWJ9LyAtRF9OT19URVNUU19ZRVQgaW5zdGFsbAogLmVuZGlmCiAuZW5kZm9yCiAKQEAgLTE2MTAs MTAgKzE2MTIsMTIgQEAgJHtfbGlifV9fTDogLlBIT05ZIC5NQUtFCiBsaWIvbGlicGFtX19MOiAu UEhPTlkgLk1BS0UKIAkke18rX31AJHtFQ0hPRElSfSAiPT09PiBsaWIvbGlicGFtIChvYmosZGVw ZW5kLGFsbCxpbnN0YWxsKSI7IFwKIAkJY2QgJHsuQ1VSRElSfS9saWIvbGlicGFtICYmIFwKLQkJ JHtNQUtFfSBESVJQUkZYPWxpYi9saWJwYW0vIG9iaiAmJiBcCi0JCSR7TUFLRX0gRElSUFJGWD1s aWIvbGlicGFtLyBkZXBlbmQgJiYgXAotCQkke01BS0V9IERJUlBSRlg9bGliL2xpYnBhbS8gLURf Tk9fTElCUEFNX1NPX1lFVCBhbGwgJiYgXAotCQkke01BS0V9IERJUlBSRlg9bGliL2xpYnBhbS8g LURfTk9fTElCUEFNX1NPX1lFVCBpbnN0YWxsCisJCSR7TUFLRX0gRElSUFJGWD1saWIvbGlicGFt LyAtRF9OT19URVNUU19ZRVQgb2JqICYmIFwKKwkJJHtNQUtFfSBESVJQUkZYPWxpYi9saWJwYW0v IC1EX05PX1RFU1RTX1lFVCBkZXBlbmQgJiYgXAorCQkke01BS0V9IERJUlBSRlg9bGliL2xpYnBh bS8gLURfTk9fVEVTVFNfWUVUIFwKKwkJICAgIC1EX05PX0xJQlBBTV9TT19ZRVQgYWxsICYmIFwK KwkJJHtNQUtFfSBESVJQUkZYPWxpYi9saWJwYW0vIC1EX05PX1RFU1RTX1lFVCBcCisJCSAgICAt RF9OT19MSUJQQU1fU09fWUVUIGluc3RhbGwKIAogX3ByZXJlcV9saWJzOiAke19wcmVyZXFfbGli czpTLyQvX19QTC99CiBfc3RhcnR1cF9saWJzOiAke19zdGFydHVwX2xpYnM6Uy8kL19fTC99Cklu ZGV4OiBzcmMvc2hhcmUvbWsvYnNkLm93bi5tawo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzcmMub3JpZy9zaGFy ZS9tay9ic2Qub3duLm1rCisrKyBzcmMvc2hhcmUvbWsvYnNkLm93bi5tawpAQCAtNTU2LDYgKzU1 NiwxMyBAQCBNS19DTEFOR19GVUxMOj0gbm8KIE1LX0xMREI6PSBubwogLmVuZGlmCiAKKy5pZiBk ZWZpbmVkKF9OT19URVNUU19ZRVQpCisjIEF0IHRoZSBiZWdpbm5pbmcgb2YgYSBmcmVzaCBidWls ZHdvcmxkLCB3ZSBtdXN0IGVuc3VyZSB0aGF0IHdlIGRvbid0CisjIGRlc2NlbmQgaW50byBhbnkg dGVzdHMvIHN1YmRpcmVjdG9yaWVzIHVudGlsIHdlIGhhdmUgYnVpbHQgYWxsIHRoZQorIyBuZWNl c3NhcnkgZGVwZW5kZW50IGxpYnJhcmllcy4KK01LX1RFU1RTOj0gbm8KKy5lbmRpZgorCiAjCiAj IFNldCBkZWZhdWx0cyBmb3IgdGhlIE1LXypfU1VQUE9SVCB2YXJpYWJsZXMuCiAjCg== --001a113490fac4fa2804ea7715a0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADyfeQW4GwhKgg4P8OWELnGWvDO8mvSjjo7Og3WMk2uxAGBGoA>