Date: Tue, 14 Sep 2010 08:30:08 GMT From: jhell <jhell@DataIX.net> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/150544: Panic, when viewing the list of ZFS snapshots Message-ID: <201009140830.o8E8U8Cp067462@freefall.freebsd.org>
index | next in thread | raw e-mail
The following reply was made to PR kern/150544; it has been noted by GNATS.
From: jhell <jhell@DataIX.net>
To: Martin Matuska <mm@freebsd.org>
Cc: Pawel Jakub Dawidek <pjd@freebsd.org>, Andriy Gapon <avg@freebsd.org>,
"Vladislav V. Prodan" <universite@ukr.net>,
bug-followup@freebsd.org
Subject: Re: kern/150544: Panic, when viewing the list of ZFS snapshots
Date: Tue, 14 Sep 2010 04:26:20 -0400
On 09/14/2010 04:15, Martin Matuska wrote:
> There was one important line missing from the merge from pjd's p4 branch.
>
> Please confirm if this patch works and I will commit it ASAP.
>
> Dňa 14. 9. 2010 10:06, jhell wrote / napísal(a):
>> On 09/14/2010 03:45, Pawel Jakub Dawidek wrote:
>>> On Tue, Sep 14, 2010 at 10:25:36AM +0300, Andriy Gapon wrote:
>>>> on 14/09/2010 09:35 Andriy Gapon said the following:
>>>>>
>>>>> Maybe this happens because we don't really support .zfs/shares, but create (or
>>>>> try to create) that directory for some reason?
>>>>>
>>>>
>>>> Could you please test this patch?
>>
>>> The problem was introduced AFAIK by Martin's import of v15. I think it
>>> is handled in my v28 properly, but would need to double check. All in
>>> all, I'd prefer if Martin could handle the problem, as I wasn't involved
>>> in v15 and it is hard to say for me in what shape it is and what bits
>>> are missing (Martin CCed).
>>
>>>> --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c
>>>> +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c
>>>> @@ -128,7 +128,6 @@ static int zfsctl_unmount_snap
>>>> */
>>>> static gfs_dirent_t zfsctl_root_entries[] = {
>>>> { "snapshot", zfsctl_mknode_snapdir, GFS_CACHE_VNODE },
>>>> - { "shares", zfsctl_mknode_shares, GFS_CACHE_VNODE },
>>>> { NULL }
>>>> };
>>
>>
>> Andriy,
>> That patch-up did solve it. As for what those shares directories are
>> good for I am not sure. Do they effect the sharenfs properties at all ?.
>> If so then I know to not apply this and to just not ls(1) or cd(1) that
>> directory until a more proper fix has been applied.
>>
>>
>> Pawel,
>> Alright future replies if I am reading into it correctly, you will be
>> removed from CC. Thank you for listening && looking in.
>>
>>
>> Regards & Thanks again,
>>
Alright patching up right now, get back to you in a moment.
--
jhell,v
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009140830.o8E8U8Cp067462>