Date: Fri, 21 May 2021 17:28:24 +0000 From: Brooks Davis <brooks@freebsd.org> To: Marcin Wojtas <mw@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: af949c590bd8 - main - Disable stack gap for ntpd during build. Message-ID: <20210521172824.GI60173@spindle.one-eyed-alien.net> In-Reply-To: <202105211334.14LDYqoa004343@gitrepo.freebsd.org> References: <202105211334.14LDYqoa004343@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--TeJTyD9hb8KJN2Jy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 21, 2021 at 01:34:52PM +0000, Marcin Wojtas wrote: > The branch main has been updated by mw: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3Daf949c590bd8a00a5973b5875d= 7e0fa6832ea64a >=20 > commit af949c590bd8a00a5973b5875d7e0fa6832ea64a > Author: Marcin Wojtas <mw@FreeBSD.org> > AuthorDate: 2021-05-21 09:29:22 +0000 > Commit: Marcin Wojtas <mw@FreeBSD.org> > CommitDate: 2021-05-21 13:33:06 +0000 >=20 > Disable stack gap for ntpd during build. > =20 > When starting, ntpd calls setrlimit(2) to limit maximum size of its > stack. The stack limit chosen by ntpd is 200K, so when stack gap > is enabled, the stack gap is larger than this limit, which results > in ntpd crashing. > =20 > Submitted by: Dawid Gorecki <dgr@semihalf.com> > Reviewed by: cy, imp > Obtained from: Semihalf > Sponsored by: Stormshield > Differential Revision: https://reviews.freebsd.org/D29553 > --- > usr.sbin/ntp/ntpd/Makefile | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/usr.sbin/ntp/ntpd/Makefile b/usr.sbin/ntp/ntpd/Makefile > index 2d8a8b9d2a2d..b9c3a05547d4 100644 > --- a/usr.sbin/ntp/ntpd/Makefile > +++ b/usr.sbin/ntp/ntpd/Makefile > @@ -56,4 +56,7 @@ CLEANFILES+=3D .version version.c > version.c: > sh -e ${.CURDIR:H}/scripts/mkver ntpd > =20 > +afterbuild: > + ${ELFCTL} -e +noaslrstkgap ${PROG} > + > .include <bsd.prog.mk> This is going to run every build and touch the file each time. It should be done as part of the link target like CTFMERGE. elfctl should also probably be taught not to write to the file if nothing changes. -- Brooks --TeJTyD9hb8KJN2Jy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJgp+23AAoJEKzQXbSebgfAUDIH/2csbDpn+XDbQQN4QAi5g/Qw Rqaqv16SytPZHXgTfDqWn7GwZ4POMtbLOEuvmZGwFEY4zSDLprgsjMEHJrtIhhHc zhlWb1Ua7s/ARNMEsZEcIcHKz0hlkCMdWh7xaWkI4uleTvhR6Q1YteqO0NfUPukm fqozGY0/QSipJm4q/e0pQkO2d3bzlcWVpyC0MXlhAZ/HGn2Oz9VecuYvKtcO12Eb P4BDnwkIUtLNwCv/IcP809jWJ1PZoxysiqtScXTjGRpPfBRZBGereOMNhW0ooxBg wjgjgTO1O2Xkb9RvglLLSotb18MsmQwGnFnhkljTc2+MCvOKMvE4GL8wWP55wf4= =VHRt -----END PGP SIGNATURE----- --TeJTyD9hb8KJN2Jy--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210521172824.GI60173>