Date: Thu, 5 Nov 2020 11:24:46 +0000 (UTC) From: Mateusz Guzik <mjg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r367368 - head/sys/fs/tmpfs Message-ID: <202011051124.0A5BOkL3099023@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mjg Date: Thu Nov 5 11:24:45 2020 New Revision: 367368 URL: https://svnweb.freebsd.org/changeset/base/367368 Log: tmpfs: reorder struct tmpfs_node to shrink it by 8 bytes The reduction (232 -> 224 bytes) allows UMA to fit one more item (17 -> 18) per slab as reported in vm.uma.TMPFS_node.keg.ipers. Modified: head/sys/fs/tmpfs/tmpfs.h Modified: head/sys/fs/tmpfs/tmpfs.h ============================================================================== --- head/sys/fs/tmpfs/tmpfs.h Thu Nov 5 11:19:31 2020 (r367367) +++ head/sys/fs/tmpfs/tmpfs.h Thu Nov 5 11:24:45 2020 (r367368) @@ -156,8 +156,10 @@ struct tmpfs_node { * when the node is removed from list and unlocked. */ LIST_ENTRY(tmpfs_node) tn_entries; /* (m) */ - bool tn_attached; /* (m) */ + /* Node identifier. */ + ino_t tn_id; /* (c) */ + /* * The node's type. Any of 'VBLK', 'VCHR', 'VDIR', 'VFIFO', * 'VLNK', 'VREG' and 'VSOCK' is allowed. The usage of vnode @@ -166,8 +168,10 @@ struct tmpfs_node { */ enum vtype tn_type; /* (c) */ - /* Node identifier. */ - ino_t tn_id; /* (c) */ + /* + * See the top comment. Reordered here to fill LP64 hole. + */ + bool tn_attached; /* (m) */ /* * Node's internal status. This is used by several file system
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202011051124.0A5BOkL3099023>