Date: Mon, 6 Oct 2003 00:57:10 +0200 From: Thomas Quinot <thomas@FreeBSD.ORG> To: Jan Stocker <Jan.Stocker@t-online.de> Cc: current@freebsd.org Subject: Re: CDROM / UDMA problem on -current (2 hours old) Message-ID: <20031005225710.GB7829@melusine.cuivre.fr.eu.org> In-Reply-To: <1065292352.606.7.camel@Twoflower.liebende.de> References: <1065292352.606.7.camel@Twoflower.liebende.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Le 2003-10-04, Jan Stocker écrivait :
> are printed so fast i cant really read .... but it must be something
> like that:
> acd1: WARNING - REQUEST_UDMA .... (error request)
> acd1: WARNING - INQUIRE_SENSE .... (retrying request)
Little can be said without complete and accurate error messages,
preferrably including a complete kernel backtrace, but still it would be
interesting to know whether the enclosed patch changes anything to your
situation.
Thomas.
Index: ata-queue.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-queue.c,v
retrieving revision 1.6
diff -u -r1.6 ata-queue.c
--- ata-queue.c 19 Sep 2003 12:46:12 -0000 1.6
+++ ata-queue.c 5 Oct 2003 22:56:28 -0000
@@ -223,7 +223,7 @@
/* if this is a UDMA CRC error, retry request */
if (request->flags & ATA_R_DMA && request->error & ATA_E_ICRC) {
- if (request->retries--) {
+ if (request->retries-- > 0) {
ata_prtdev(request->device,
"WARNING - %s UDMA ICRC error (retrying request)\n",
ata_cmd2str(request));
--
Thomas.Quinot@Cuivre.FR.EU.ORG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031005225710.GB7829>