Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Jun 2020 07:05:03 +0000 (UTC)
From:      Toomas Soome <tsoome@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r362217 - head/stand/common
Message-ID:  <202006160705.05G753T4057972@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tsoome
Date: Tue Jun 16 07:05:03 2020
New Revision: 362217
URL: https://svnweb.freebsd.org/changeset/base/362217

Log:
  loader: variable i is unused without MBR/GPT support built in
  
  Because i is only used as index in for loop, declare it in for statement.
  
  Sponsored by:	Netflix, Klara Inc.

Modified:
  head/stand/common/part.c

Modified: head/stand/common/part.c
==============================================================================
--- head/stand/common/part.c	Tue Jun 16 04:17:08 2020	(r362216)
+++ head/stand/common/part.c	Tue Jun 16 07:05:03 2020	(r362217)
@@ -647,7 +647,6 @@ ptable_open(void *dev, uint64_t sectors, uint16_t sect
 	struct dos_partition *dp;
 	struct ptable *table;
 	uint8_t *buf;
-	int i;
 #ifdef LOADER_MBR_SUPPORT
 	struct pentry *entry;
 	uint32_t start, end;
@@ -720,7 +719,7 @@ ptable_open(void *dev, uint64_t sectors, uint16_t sect
 	 * start sector 1. After DOSPTYP_PMBR, there may be other partitions.
 	 * UEFI compliant PMBR has no other partitions.
 	 */
-	for (i = 0; i < NDOSPART; i++) {
+	for (int i = 0; i < NDOSPART; i++) {
 		if (dp[i].dp_flag != 0 && dp[i].dp_flag != 0x80) {
 			DPRINTF("invalid partition flag %x", dp[i].dp_flag);
 			goto out;
@@ -742,7 +741,7 @@ ptable_open(void *dev, uint64_t sectors, uint16_t sect
 	/* Read MBR. */
 	DPRINTF("MBR detected");
 	table->type = PTABLE_MBR;
-	for (i = has_ext = 0; i < NDOSPART; i++) {
+	for (int i = has_ext = 0; i < NDOSPART; i++) {
 		if (dp[i].dp_typ == 0)
 			continue;
 		start = le32dec(&(dp[i].dp_start));



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202006160705.05G753T4057972>