Date: Tue, 25 May 2004 21:47:57 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: Yar Tikhiy <yar@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h Message-ID: <20040525184757.GA5546@ip.net.ua> In-Reply-To: <20040525173458.GA18554@comp.chem.msu.su> References: <200405251449.i4PEnkIa098672@repoman.freebsd.org> <20040525164251.GA3245@ip.net.ua> <20040525173458.GA18554@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
--tKW2IUtsqtDRztdT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 25, 2004 at 09:34:59PM +0400, Yar Tikhiy wrote: > On Tue, May 25, 2004 at 07:42:51PM +0300, Ruslan Ermilov wrote: > > On Tue, May 25, 2004 at 07:49:46AM -0700, Yar Tikhiy wrote: > > > yar 2004/05/25 07:49:46 PDT > > >=20 > > > FreeBSD src repository > > >=20 > > > Modified files: > > > sys/dev/fxp if_fxp.c if_fxpvar.h=20 > > > Log: > > > Teach fxp(4) to control VLAN_MTU in the hardware. > > > Now reception of extended frames can be toggled > > > through ioctl(SIOCSIFCAP). > > > =20 > > > The card will also receive extended frames when > > > in promiscuous mode. > > > =20 > > > Revision Changes Path > > > 1.209 +16 -8 src/sys/dev/fxp/if_fxp.c > > > 1.30 +1 -0 src/sys/dev/fxp/if_fxpvar.h > > >=20 > > This change also made VLAN_MTU disabled by default, what was > > the reason to do it? >=20 > I disabled it so that the interface won't violate without need > the Ethernet standard WRT the upper limit on frame size. >=20 What clause and in which of many 802 standards do you refer to? > vlan(4) will enable VLAN_MTU on an fxp interace as soon as a vlan > interface is attached to it. >=20 vlan(4) may not be the only consumer of VLAN capable frames. For example, I have ng_vlan(4) connected to ng_ether(4) node, and doing VLAN processing here, and this change will break the existing and working config. I can survive, but it sounds against POLA to me. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAs5TdUkv4P6juNwoRAvfFAJ4oiTM2ZbjWAImdjLjvFHzR2vWvXACfeDB+ JQMdW330ygL76W3s5KdENsA= =vrPa -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040525184757.GA5546>