Date: Mon, 14 Jul 1997 11:35:41 +0200 (MET DST) From: Luigi Rizzo <luigi@labinfo.iet.unipi.it> To: multimedia@freebsd.org Subject: guspnp9 - sb recording bug Message-ID: <199707140935.LAA10468@labinfo.iet.unipi.it>
next in thread | raw e-mail | index | archive | help
> It is hard for me to read the differences between guspnp7 and guspnp9 given
> that guspnp9 was run thru indent. Typically , this should be done
> after all the changes have gone in and the driver was tested.
I had no choice, my mind refuses to work on ugly-looking code :)
In any case, one solution is to run the old code through indent and
then try a "diff".
If someone has problems recording with the sb (perhaps in 16-bit
mode) note that in snd970711 (and then in guspnp9 ?) there was a
typo in sb_dsp.c. In sb_dsp_start_input(), around line 404, you
should apply the following fix
if (sb_dsp_command(DSP_CMD_HSSIZE)) { /* High speed size */
sb_dsp_command((u_char) (dsp_count & 0xff));
sb_dsp_command((u_char) ((dsp_count >> 8) & 0xff));
- sb_dsp_command(DSP_CMD_HSDAC); /* High speed 8 bit ADC */
+ sb_dsp_command(DSP_CMD_HSADC); /* High speed 8 bit ADC */
} else
printf("SB Error: Unable to start (high speed) ADC\n");
splx(flags);
} else {
The correct definition in file sb_card.h should be:
#define DSP_CMD_HSDAC 0x91 /* high speed dac */
#define DSP_CMD_HSADC 0x99 /* high speed adc */
Boy, I hope that's all by now. Thanks everybody for all the testing
and feedback you have provided.
Cheers
Luigi
-----------------------------+--------------------------------------
Luigi Rizzo | Dip. di Ingegneria dell'Informazione
email: luigi@iet.unipi.it | Universita' di Pisa
tel: +39-50-568533 | via Diotisalvi 2, 56126 PISA (Italy)
fax: +39-50-568522 | http://www.iet.unipi.it/~luigi/
_____________________________|______________________________________
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199707140935.LAA10468>