Date: Thu, 9 Mar 2006 11:03:07 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.README Message-ID: <20060309090307.GK54826@ip.net.ua> In-Reply-To: <200603090133.k291XcfB005631@repoman.freebsd.org> References: <200603090133.k291XcfB005631@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Mar 09, 2006 at 01:33:38AM +0000, Warner Losh wrote:
> imp 2006-03-09 01:33:38 UTC
>
> FreeBSD src repository
>
> Modified files:
> share/mk bsd.README
> Log:
> Now that we now spell NO_MAN=xxx MAN=, update the docs.
>
> Submitted by: John Hein
>
> Revision Changes Path
> 1.30 +1 -1 src/share/mk/bsd.README
>
I object.
1) This is not common:
grep '^NO_MAN=' {bin,usr.bin,sbin,usr.sbin}/*/Makefile |wc -l
10
grep '^MAN=[[:space:]]*(#.*)?$' {bin,usr.bin,sbin,usr.sbin}/*/Makefile |wc -l
0
2) MAN= is worse for performance (with NO_MAN, bsd.man.mk is not
processes at all which is faster).
3) This is in contrast with NO_OBJ and similar knobs.
I can only suggest to make it spell "NO_MAN=", i.e., without any value.
Was there some discussion that I've missed?
Cheers,
--
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQFED+9KqRfpzJluFF4RAgnBAJoD2V9l+X5tjwOocTLPPn0ScJV3/QCfSSGJ
UqQ6RPhHjNOyfcss59hTiLw=
=Gm6V
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060309090307.GK54826>