Date: Fri, 21 Mar 2003 09:59:37 -0800 (PST) From: Nate Lawson <nate@root.org> To: "Matthew N. Dodd" <mdodd@FreeBSD.ORG> Cc: current@FreeBSD.ORG, wpaul@FreeBSD.ORG Subject: Re: Updated if_* attach/detach patches Message-ID: <Pine.BSF.4.21.0303210958230.15977-100000@root.org> In-Reply-To: <20030321095558.O8716@sasami.jurai.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 21 Mar 2003, Matthew N. Dodd wrote: > On Wed, 19 Mar 2003, Nate Lawson wrote: > > Patches are at: > > http://www.root.org/~nate/freebsd/if_pci/ > > I'd like to see calls to mtx_destroy() protected by a test for > mtx_initialized(). > > In most cases this isn't strictly necessary but its not bad practice. Perhaps I should add a comment mentioning my assumption: mtx_init is one of the first things called and since detach unconditionally locks the mtx, it should never be called unless the mutex is initialized. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0303210958230.15977-100000>