Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Feb 2025 14:04:38 GMT
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 0b29ef1e3fd5 - stable/13 - icmp: allow zero value for ICMP limits
Message-ID:  <202502121404.51CE4cf7042154@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=0b29ef1e3fd57940704dd40a834f98649adbe46e

commit 0b29ef1e3fd57940704dd40a834f98649adbe46e
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2024-03-25 02:52:03 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-02-12 14:03:22 +0000

    icmp: allow zero value for ICMP limits
    
    Zero means limit is disabled, so the value doesn't need to be checked
    against jitter value.
    
    Fixes:  ac44739fd834f51cacb26485a4140fd482e20150
    Fixes:  a03aff88a14448c3084a0384082ec996d7213897
    (cherry picked from commit 4399e055ea610cdefa1470ad1ee614dd81ba5e56)
---
 sys/netinet/ip_icmp.c | 2 +-
 sys/netinet6/icmp6.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/netinet/ip_icmp.c b/sys/netinet/ip_icmp.c
index 0d671033b67c..8ad6191f3097 100644
--- a/sys/netinet/ip_icmp.c
+++ b/sys/netinet/ip_icmp.c
@@ -1129,7 +1129,7 @@ sysctl_icmplim_and_jitter(SYSCTL_HANDLER_ARGS)
 	error = sysctl_handle_int(oidp, &new, 0, req);
 	if (error == 0 && req->newptr) {
 		if (lim) {
-			if (new <= V_icmplim_jitter)
+			if (new != 0 && new <= V_icmplim_jitter)
 				error = EINVAL;
 			else
 				V_icmplim = new;
diff --git a/sys/netinet6/icmp6.c b/sys/netinet6/icmp6.c
index e1b0196fc62b..646c73e8abf0 100644
--- a/sys/netinet6/icmp6.c
+++ b/sys/netinet6/icmp6.c
@@ -2843,7 +2843,7 @@ sysctl_icmp6lim_and_jitter(SYSCTL_HANDLER_ARGS)
 	error = sysctl_handle_int(oidp, &new, 0, req);
 	if (error == 0 && req->newptr) {
 		if (lim) {
-			if (new <= V_icmp6lim_jitter)
+			if (new != 0 && new <= V_icmp6lim_jitter)
 				error = EINVAL;
 			else
 				V_icmp6errppslim = new;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502121404.51CE4cf7042154>