Date: Tue, 05 Apr 2016 23:08:40 +0200 From: Michelle Sullivan <michelle@sorbs.net> To: Kurt Jaeger <lists@opsec.eu>, Martin Waschbuesch <martin@waschbuesch.de>, ports@freebsd.org Subject: Re: Committer needed for PR 208029 Message-ID: <57042958.5010701@sorbs.net> In-Reply-To: <20160405200835.GM35640@home.opsec.eu> References: <498CA3F8-15EF-45BD-880C-241F83CBE3DD@waschbuesch.de> <20160405185159.GK35640@home.opsec.eu> <20160405200835.GM35640@home.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
Kurt Jaeger wrote: > Hi! > >> I'm testbuilding those ports right now and find that >> they fail on 9.3amd64 with: > With this in the -server Makefile, all is fine. > > .if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000000 > WITH_OPENSSL_PORT=yes > .endif > Umm probably a really bad idea... consider this or something more creative/descriptive: .if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000000 && ${WITH_OPENSSL_PORT} != "yes" BROKEN= You must set WITH_OPENSSL_PORT=yes in /etc/make.conf on Pre 10.x .endif ... the idea instead of silently turning it on which could cause a myriad of hell for production systems where some ports are compiled against security/openssl and some against the base openssl... stop the compile and tell the user what they have to do to resolve it... which will then make anything else use the same openssl and lessen the dependency/library issues that could happen. Regards, -- Michelle Sullivan http://www.mhix.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57042958.5010701>