Date: Wed, 31 Jan 2018 08:14:03 -0800 From: John Baldwin <jhb@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: Wojciech Macek <wma@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328610 - head/sys/amd64/amd64 Message-ID: <3114578.qyyx4qh6ii@ralph.baldwin.cx> In-Reply-To: <CAPyFy2AmU%2B1pPNU=W_FbG2=u4xKXNQHifaruOH6b=W%2Bn1juw_Q@mail.gmail.com> References: <201801302329.w0UNTRHn080138@repo.freebsd.org> <3195814.6PcFLP86qD@ralph.baldwin.cx> <CAPyFy2AmU%2B1pPNU=W_FbG2=u4xKXNQHifaruOH6b=W%2Bn1juw_Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, January 31, 2018 10:31:36 AM Ed Maste wrote: > On 30 January 2018 at 21:01, John Baldwin <jhb@freebsd.org> wrote: > > On Tuesday, January 30, 2018 11:29:27 PM John Baldwin wrote: > >> Author: jhb > >> Date: Tue Jan 30 23:29:27 2018 > >> New Revision: 328610 > >> URL: https://svnweb.freebsd.org/changeset/base/328610 > >> > >> Log: > >> Ensure 'name' is not NULL before passing to strcmp(). > >> > >> This avoids a nested page fault when obtaining a stack trace in DDB if > >> the address from the first frame does not resolve to a known symbol. > >> > >> MFC after: 1 week > >> Sponsored by: Chelsio Communications > > > > This appears to be fallout from lld? After fixing this, the stack trace > > for my next panic shows no symbols for functions in the kernel, only > > functions in kernel modules: > > It's fallout from loader changes in r328536. I reverted r328536 (and > r328603) locally and stack traces are fixed. Ouch. I'll try to look at this later today unless someone else beats me to it. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3114578.qyyx4qh6ii>