Date: Sat, 29 Jul 2017 22:11:26 +0200 From: Zbigniew Bodek <zbb@freebsd.org> To: Ian Lepore <ian@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r321633 - in head/sys/arm: arm include Message-ID: <CALF_Txmy3uY80gznVdWkiMiaxp4AyAKwTrudyLw-fFOyE6B1Mw@mail.gmail.com> In-Reply-To: <1501344365.90400.99.camel@freebsd.org> References: <201707272314.v6RNEHwQ033479@repo.freebsd.org> <1501344365.90400.99.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2017-07-29 18:06 GMT+02:00 Ian Lepore <ian@freebsd.org>: > On Thu, 2017-07-27 at 23:14 +0000, Zbigniew Bodek wrote: >> Author: zbb >> Date: Thu Jul 27 23:14:17 2017 >> New Revision: 321633 >> URL: https://svnweb.freebsd.org/changeset/base/321633 >> >> Log: >> Fix TEX index acquisition using L2 attributes >> >> The TEX index is selected using (TEX0 C B) bits >> from the L2 descriptor. Use correct index by masking >> and shifting those bits accordingly. >> >> Differential Revision: https://reviews.freebsd.org/D11703 > > How did you guys discover this bug, like what were the symptoms? Hello Ian, We had bug in usage of pmap_remap_vm_attr() and fixing it didn't help for the issue so the second bug has been found here. > Should we consider merging this to 11-stable? As far as I know nobody besides Armada38x is using this function in HEAD and nobody uses it in 11. You may merge it to 11 though (just for the safety of this code in the future). > > -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALF_Txmy3uY80gznVdWkiMiaxp4AyAKwTrudyLw-fFOyE6B1Mw>