Date: Sat, 22 Dec 2007 04:01:56 +0000 From: "Wojciech A. Koszek" <wkoszek@freebsd.org> To: freebsd-current@freebsd.org Cc: emax@freebsd.org Subject: [RFC, PATCH] Getting rid of direct calls to keyboard's methods via kbdsw[] array Message-ID: <20071222040156.GA87017@FreeBSD.czest.pl>
next in thread | raw e-mail | index | archive | help
Hello, In the FreeBSD kernel we have notion of keyboard represented by "keyboard_t" type. We operate on such structures throught another keyboard_switch structure. It lets us to use keyboard API without distinguishing exactly which hardware we're working with. My proposal is to unify a way in which we call such specialized methods, so that instead of direct array indexing used to call specific keyboard method: (*kbdsw[(kbd)->kb_index]->enable)((kbd)) We would use unified interface: kbdd_enable(kbd) Proposed patch is here: http://people.freebsd.org/~wkoszek/patches/tty/kbdcleanup.patch Suggestions are welcome. Thanks, -- Wojciech A. Koszek wkoszek@FreeBSD.org http://FreeBSD.czest.pl/dunstan/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071222040156.GA87017>