Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Apr 2019 11:53:45 -0700
From:      Enji Cooper <yaneurabeya@gmail.com>
To:        Li-Wen Hsu <lwhsu@FreeBSD.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r346160 - head/usr.bin/mandoc
Message-ID:  <5DF1F115-692D-48B7-A52C-AD1BF5E738E5@gmail.com>
In-Reply-To: <201904121835.x3CIZETP017600@repo.freebsd.org>
References:  <201904121835.x3CIZETP017600@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help


> On Apr 12, 2019, at 11:35 AM, Li-Wen Hsu <lwhsu@FreeBSD.org> wrote:
> 
> Author: lwhsu
> Date: Fri Apr 12 18:35:14 2019
> New Revision: 346160
> URL: https://svnweb.freebsd.org/changeset/base/346160
> 
> Log:
>  Suppress old gcc warning about null format string
> 
>  This is workaround to make head build on gcc using architectures
> 
>  Sponsored by:	The FreeBSD Foundation
>  MFC-with:	r346149
> 
> Modified:
>  head/usr.bin/mandoc/Makefile
> 
> Modified: head/usr.bin/mandoc/Makefile
> ==============================================================================
> --- head/usr.bin/mandoc/Makefile	Fri Apr 12 18:13:57 2019	(r346159)
> +++ head/usr.bin/mandoc/Makefile	Fri Apr 12 18:35:14 2019	(r346160)
> @@ -97,6 +97,8 @@ SRCS=		${LIB_SRCS} \
> WARNS?=	3
> CFLAGS+= -DHAVE_CONFIG_H \
> 	 -I${SRCTOP}/lib/libopenbsd/
> +# This can be removed after swtiching to newer gcc
> +CFLAGS.gcc+=	-Wno-format
> LIBADD=	openbsd z
> 
> .include <bsd.prog.mk>

	Couldn’t this be fixed upstream and pulled back in, instead of ignoring the warning?
Cheers,
-Enji


Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5DF1F115-692D-48B7-A52C-AD1BF5E738E5>