Date: Tue, 15 Jun 2004 16:11:01 -0700 From: "David O'Brien" <obrien@freebsd.org> To: Scott Long <scottl@freebsd.org> Cc: Joseph Dunn <joseph@magnesium.net> Subject: Re: cvs commit: src/sys/dev/sound/pci emu10k1.c Message-ID: <20040615231101.GA13516@dragon.nuxi.com> In-Reply-To: <40CF67AA.50600@freebsd.org> References: <200406132212.i5DMC3b9075832@repoman.freebsd.org> <20040614011012.H1600@newtrinity.zeist.de> <20040614010854.GA98360@dragon.nuxi.com> <40CCFCDF.4040303@freebsd.org> <20040615160107.GT10016@spiff.melthusia.org> <40CF67AA.50600@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 15, 2004 at 03:18:34PM -0600, Scott Long wrote: > It's fine to put an unknown ID into a driver to do local testing and > discovery. It's less acceptable to commit that change to FreeBSD CVS > without knowing what it does and what impact it has. Anyways, this > has been kicked around enough and I believe that David already said > that he will back out the change. I didn't say I plan to back it out -- I said if pushed to I would. Meaning I wont fight much for it. I still think there is definate worth in having the probe message identify the Dell part (so we can find testers). There is no bug report against the driver in 5-CURRENT (which I updated post 5.2.1). This is has gotten into bikeshead teritory, especially since I'm the closest thing we've had to a emu10k1 maintainer in 2-3 years. As other have said: A sound driver probing, attaching, and failing to work is orders of magnitude less an issue than for some other classes of drivers. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040615231101.GA13516>