Date: Thu, 26 Jul 2018 23:44:12 +0900 From: =?utf-8?B?5b6M6Jek5aSn5Zyw?= <daichigoto@icloud.com> To: rgrimes@freebsd.org Cc: Daichi GOTO <daichi@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336737 - head/usr.bin/top Message-ID: <32C0FF83-9BE2-4950-9FFD-1FA10463C535@icloud.com> In-Reply-To: <201807261422.w6QEMUwH046070@pdx.rh.CN85.dnsmgr.net> References: <201807261422.w6QEMUwH046070@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
I see. thank you for the advice! > 2018/07/26 23:22=E3=80=81Rodney W. Grimes = <freebsd@pdx.rh.CN85.dnsmgr.net>=E3=81=AE=E3=83=A1=E3=83=BC=E3=83=AB: >=20 >> Author: daichi >> Date: Thu Jul 26 13:53:22 2018 >> New Revision: 336737 >> URL: https://svnweb.freebsd.org/changeset/base/336737 >>=20 >> Log: >> top(1): forgot in r336160 >=20 > It is helpful to say what was forgot in the commit message as when > you are reading a svn log output you do not have the diff to show > you what it was that has been forgot. >=20 > Better message would of been: > Remove utf8strvisx prototype, forgotten in r336160 >=20 >=20 > Thanks, > Rod >>=20 >> Approved by: gnn (mentor) >> Differential Revision: https://reviews.freebsd.org/D16452 >>=20 >> Modified: >> head/usr.bin/top/utils.h >>=20 >> Modified: head/usr.bin/top/utils.h >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/usr.bin/top/utils.h Thu Jul 26 13:33:10 2018 = (r336736) >> +++ head/usr.bin/top/utils.h Thu Jul 26 13:53:22 2018 = (r336737) >> @@ -22,5 +22,4 @@ const char *format_time(long); >> char *format_k(int64_t); >> int string_index(const char *string, const char * const *array); >> int find_pid(pid_t pid); >> -int utf8strvisx(char *, const char *, size_t); >>=20 >>=20 >>=20 >=20 > --=20 > Rod Grimes = rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?32C0FF83-9BE2-4950-9FFD-1FA10463C535>