Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Jan 1999 00:10:35 -0800 (PST)
From:      Bruce Evans <bde@FreeBSD.ORG>
To:        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   cvs commit: src/sys/kern sys_generic.c
Message-ID:  <199901290810.AAA38057@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

bde         1999/01/29 00:10:35 PST

  Modified files:
    sys/kern             sys_generic.c 
  Log:
  Removed a bogus cast to c_caddr_t.  This is part of terminating
  c_caddr_t with extreme prejudice.  Here the point of the original
  cast to caddr_t was to break the warning about the const mismatch
  between write(2)'s `const void *buf' and `struct uio's `char
  *iov_base' (previous bitrot gave a gratuitous dependency on caddr_t
  being char *).  Compiling with -Wcast-qual made the cast a full
  no-op.
  
  This change has no effect on the warning for discarding `const'
  on assignment to iov_base.  The warning should not be fixed by
  splitting `struct iovec' into a non-const version for read()
  and a const version for write(), since correct const poisoning
  would affect all pointers to i/o addresses.  Const'ness should
  probably be forgotten by not declaring it in syscalls.master.
  
  Revision  Changes    Path
  1.45      +2 -2      src/sys/kern/sys_generic.c

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901290810.AAA38057>