Date: Tue, 09 Dec 1997 08:51:37 +0200 From: Mark Murray <mark@grondar.za> To: Sheldon Hearn <axl@iafrica.com> Cc: freebsd-ports@FreeBSD.ORG Subject: Re: Possible problem with ftpd 6.00 Message-ID: <199712090651.IAA13796@greenpeace.grondar.za>
next in thread | raw e-mail | index | archive | help
Sheldon Hearn wrote:
> [A] Ownership
>
> It currently installs aftpd into ${PREFIX}/libexec owned by bin:bin .
> The ownership doesn't seem to matter much because:
>
> 1) it's called from inetd and run as root
>
> 2) it needs root priveledge to chroot into /home/ftp
>
> 3) it does set{gu}id to ftp:operator as soon as the chroot is done
>
> Should I be pedantic and install with different ownership?
No.
> [B] Compiled defaults
>
> As per mjr's recommendation in the README file, I've hardcoded the
> desired ftp chroot dir into the binary. It can still be overrided using
> command line options (mjr's concerns about passing arguments from inetd
> don't apply to FreeBSD's inetd).
>
> Is /home/ftp a religiously sound default?
Yuk. It should really use user ftp's home dir from /etc/passwd.
> Also, is it acceptable for me to use UID 14 and GID 5 for ftp:operator
> or should I be getting a script to dig those numbers out of /etc/* at
> the configure stage?
No. The script to discover what they actually are is necessary.
> [C] Source patch review
>
> A small change to the source was required for building on 2.2-RELENG
> (untested on -CURRENT). From my understanding of the philosophy behind
> C, I've done the right thing. but I have no programming experience to
> validate my whim.
>
> What is the best way for me to have the change I've made to the source
> code reviewed prior to port submission?
You just did it. :-). Ask on this list.
M
--
Mark Murray
Join the anti-SPAM movement: http://www.cauce.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199712090651.IAA13796>