Date: Tue, 13 Aug 2013 12:16:24 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r254275 - head/sys/geom/raid Message-ID: <5209F968.4090301@FreeBSD.org> In-Reply-To: <5209F2E0.9000901@FreeBSD.org> References: <201308130756.r7D7uf9o086164@svn.freebsd.org> <5209F2E0.9000901@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13.08.2013 11:48, Andriy Gapon wrote:
> on 13/08/2013 10:56 Alexander Motin said the following:
>> + /* Deny write opens for read-only volumes. */
>> + if (vol->v_read_only && acw > 0) {
>> + error = EROFS;
>> + goto out;
>> + }
>
> I'd like to stir a small (hopefully) discussion (again, hopefully): is EROFS
> appropriate here or would ENODEV be better?
>
> EROFS Read-only filesystem
> ENODEV Operation not supported by device
I've seen both options and have no strong opinion here. Quick search via
sources shown that some thing such as md(4) use EROFS. If that is wrong,
lets fix it globally and forget.
--
Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5209F968.4090301>