Date: Wed, 16 Apr 2008 10:17:28 -0700 From: Marcel Moolenaar <xcllnt@mac.com> To: Rafal Jaworowski <raj@semihalf.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Marius Strobl <marius@alchemy.franken.de> Subject: Re: cvs commit: src/sys/boot/common dev_net.c src/sys/boot/uboot/lib console.c copy.c glue.c libuboot.h net.c time.c Message-ID: <5B2C1F89-ADF7-4322-9753-5E7E1A79CD0E@mac.com> In-Reply-To: <4805DE07.8050008@semihalf.com> References: <200803121601.m2CG1ZbG072258@repoman.freebsd.org> <20080412221501.GB44768@alchemy.franken.de> <4805DE07.8050008@semihalf.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Apr 16, 2008, at 4:07 AM, Rafal Jaworowski wrote: >> On at least sparc64 reverting this causes ofwn_init() to be called >> over and over again, which doesn't seem to be the right thing to do >> either. > > I think this is expected: the loader/libstand seem to call > devopen()->net_open(), devclose()->net_close() upon each file > access, but it > doesn't seem harmful, only additional output is seen in this case. The additional output is still an eyesore :-) Your change is correct, but it does expose a more fundamental problem with the loader for which we may not have the gumption to fix (as demonstrated by revision 1.7). The bottom-line being that we should not open and close devices wishy-washy. -- Marcel Moolenaar xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5B2C1F89-ADF7-4322-9753-5E7E1A79CD0E>