Date: Wed, 10 Nov 2010 02:10:48 GMT From: Eitan Adler <lists@eitanadler.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/152090: [patch] actually use defaultval instead of $$3 Message-ID: <201011100210.oAA2AmhS049085@www.freebsd.org> Resent-Message-ID: <201011100220.oAA2KADr061030@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 152090
>Category: ports
>Synopsis: [patch] actually use defaultval instead of $$3
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Nov 10 02:20:09 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Eitan Adler
>Release:
>Organization:
>Environment:
>Description:
Looking through the source of bsd.port.mk I noticed that defaultval was assigned to $$3 but was never actually used. Attached is a patch to make the code clearer.
>How-To-Repeat:
>Fix:
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.654
diff -u -r1.654 bsd.port.mk
--- bsd.port.mk 8 Nov 2010 16:07:03 -0000 1.654
+++ bsd.port.mk 10 Nov 2010 01:57:25 -0000
@@ -6035,7 +6035,7 @@
elif [ ! -z "$${withoutval}" ]; then \
val=off; \
else \
- val=$$3; \
+ val=$${defaultval}; \
fi; \
DEFOPTIONS="$${DEFOPTIONS} $$1 \"$$2\" $${val}"; \
shift 3; \
@@ -6140,7 +6140,7 @@
elif [ ! -z "$${withoutval}" ]; then \
val=off; \
else \
- val="$$3 (default)"; \
+ val="$${defaultval} (default)"; \
fi; \
${ECHO_MSG} " $$1=$${val} \"$$2\""; \
shift 3; \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011100210.oAA2AmhS049085>