Date: Sun, 12 Apr 2026 03:16:29 +0000 From: Kyle Evans <kevans@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Abdelkader Boudih <freebsd@seuros.com> Subject: git: caa3700d7ace - stable/15 - firmware: Fix inverted FIRMWARE_GET_NOWARN logic Message-ID: <69db0e8d.469f4.4186000d@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch stable/15 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=caa3700d7ace41ea61d43502ac872b67ce0b1ccf commit caa3700d7ace41ea61d43502ac872b67ce0b1ccf Author: Abdelkader Boudih <freebsd@seuros.com> AuthorDate: 2026-01-30 00:02:47 +0000 Commit: Kyle Evans <kevans@FreeBSD.org> CommitDate: 2026-04-12 03:15:11 +0000 firmware: Fix inverted FIRMWARE_GET_NOWARN logic The try_binary_file() function has inverted logic for the FIRMWARE_GET_NOWARN flag. When the flag is set (meaning "don't warn"), the code sets warn=true and makes noise anyway. Invert the assignment to warn to correctly suppress warnings when FIRMWARE_GET_NOWARN is set. Reviewed by: kevans (cherry picked from commit fdcd67be8274d237ae2c87d6475d9d34b440b8d8) --- sys/kern/subr_firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/subr_firmware.c b/sys/kern/subr_firmware.c index d616339f2c07..88b2e71ba8df 100644 --- a/sys/kern/subr_firmware.c +++ b/sys/kern/subr_firmware.c @@ -281,7 +281,7 @@ try_binary_file(const char *imagename, uint32_t flags) int oflags; size_t resid; int error; - bool warn = flags & FIRMWARE_GET_NOWARN; + bool warn = (flags & FIRMWARE_GET_NOWARN) == 0; /* * XXX TODO: Loop over some path instead of a single element path.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69db0e8d.469f4.4186000d>