Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Nov 2016 14:07:43 -0600
From:      Justin Hibbits <chmeeedalf@gmail.com>
To:        Alan Cox <alc@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r309017 - in head/sys: cddl/compat/opensolaris/sys compat/linprocfs fs/tmpfs sys vm
Message-ID:  <762C1A8D-D1A5-486E-AC52-969AE1F2F45A@gmail.com>
In-Reply-To: <201611221813.uAMIDkHQ071392@repo.freebsd.org>
References:  <201611221813.uAMIDkHQ071392@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Nov 22, 2016, at 12:13 PM, Alan Cox wrote:

> Author: alc
> Date: Tue Nov 22 18:13:46 2016
> New Revision: 309017
> URL: https://svnweb.freebsd.org/changeset/base/309017
>
> Log:
>  Remove PG_CACHED-related fields from struct vmmeter, because they  
> are no
>  longer used.  More precisely, they are always zero because the code  
> that
>  decremented and incremented them no longer exists.
>
>  Bump __FreeBSD_version to mark this change.
>
>  Reviewed by:	kib, markj
>  Sponsored by:	Dell EMC Isilon
>  Differential Revision:	https://reviews.freebsd.org/D8583
>
> Modified:
>  head/sys/cddl/compat/opensolaris/sys/kmem.h
>  head/sys/compat/linprocfs/linprocfs.c
>  head/sys/fs/tmpfs/tmpfs_subr.c
>  head/sys/sys/param.h
>  head/sys/sys/vmmeter.h
>  head/sys/vm/swap_pager.c
>  head/sys/vm/vm_meter.c
>  head/sys/vm/vm_page.c
>  head/sys/vm/vnode_pager.c
>
> Modified: head/sys/sys/vmmeter.h
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- head/sys/sys/vmmeter.h	Tue Nov 22 18:13:04 2016	(r309016)
> +++ head/sys/sys/vmmeter.h	Tue Nov 22 18:13:46 2016	(r309017)
> @@ -80,7 +80,6 @@ struct vmmeter {
> 	u_int v_pdpages;	/* (p) pages analyzed by daemon */
> 	u_int v_pdshortfalls;	/* (p) page reclamation shortfalls */
>
> -	u_int v_tcached;	/* (p) total pages cached */
> 	u_int v_dfree;		/* (p) pages freed by daemon */
> 	u_int v_pfree;		/* (p) pages freed by exiting processes */
> 	u_int v_tfree;		/* (p) total pages freed */
> @@ -98,7 +97,6 @@ struct vmmeter {
> 	u_int v_inactive_target; /* (c) pages desired inactive */
> 	u_int v_inactive_count;	/* (q) pages inactive */
> 	u_int v_laundry_count;	/* (q) pages eligible for laundering */
> -	u_int v_cache_count;	/* (f) pages on cache queue */
> 	u_int v_pageout_free_min;   /* (c) min pages reserved for kernel */
> 	u_int v_interrupt_free_min; /* (c) reserved pages for int code */
> 	u_int v_free_severe;	/* (c) severe page depletion point */

Removing these fields cause build failures, at least with MPC85XX/ 
MPC85XXSPE (see make universe), because it ends up changing the size  
of struct pcpu.

- Justin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?762C1A8D-D1A5-486E-AC52-969AE1F2F45A>