Date: Tue, 1 Mar 2011 09:46:14 +0100 From: Hans Petter Selasky <hselasky@c2i.net> To: freebsd-usb@freebsd.org Cc: Carl <k0802647@telus.net> Subject: Re: why does ulpt depend on ucom? Message-ID: <201103010946.14791.hselasky@c2i.net> In-Reply-To: <201103010933.39054.hselasky@c2i.net> References: <4D6C829F.6090709@telus.net> <51ED50BF-C3B2-42C5-8E8A-D88DCC266EF6@gsoft.com.au> <201103010933.39054.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Boundary-00=_WJLbNEz4pztMtC9 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit On Tuesday 01 March 2011 09:33:38 Hans Petter Selasky wrote: > On Tuesday 01 March 2011 07:31:00 Daniel O'Connor wrote: > > On 01/03/2011, at 15:52, Carl wrote: > > > /usr/src/sys/conf/files causes the ucom driver to be compiled into the > > > kernel if ulpt is specified for inclusion. Why? ucom provides support > > > for USB tty. > > > > Looks like a bug, specifically the second to last line of > > /usr/src/sys/dev/usb/serial/ulpt.c > > You are right. > > > Also, I'm not really sure why ulpt.c is in the serial directory but that > > isn't a big issue. Please try the attached patch and report back. --HPS --Boundary-00=_WJLbNEz4pztMtC9 Content-Type: text/x-patch; charset="iso-8859-1"; name="ulpt_depend.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ulpt_depend.patch" === sys/dev/usb/serial/ulpt.c ================================================================== --- sys/dev/usb/serial/ulpt.c (revision 219105) +++ sys/dev/usb/serial/ulpt.c (local) @@ -743,5 +743,4 @@ DRIVER_MODULE(ulpt, uhub, ulpt_driver, ulpt_devclass, NULL, 0); MODULE_DEPEND(ulpt, usb, 1, 1, 1); -MODULE_DEPEND(ulpt, ucom, 1, 1, 1); MODULE_VERSION(ulpt, 1); === sys/conf/files ================================================================== --- sys/conf/files (revision 219105) +++ sys/conf/files (local) @@ -1874,7 +1874,7 @@ dev/usb/serial/uvscom.c optional uvscom dev/usb/serial/usb_serial.c optional ucom | u3g | uark | ubsa | ubser | \ uchcom | ucycom | ufoma | uftdi | \ - ugensa | uipaq | ulpt | umct | \ + ugensa | uipaq | umct | \ umodem | umoscom | uplcom | uslcom | \ uvisor | uvscom # --Boundary-00=_WJLbNEz4pztMtC9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103010946.14791.hselasky>