Date: Tue, 22 Dec 2015 17:54:30 -0600 From: Justin Hibbits <chmeeedalf@gmail.com> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Ed Maste <emaste@freebsd.org>, Alan Cox <alc@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r292469 - in head/sys: dev/drm2/ttm mips/include mips/mips vm Message-ID: <CAHSQbTAMHsrOPMR_ikk2XBSBPpSpfcEbh607iRpN-TJEREoFDQ@mail.gmail.com> In-Reply-To: <610A02A5-1399-4A6C-993C-CDCC9DC8502A@gmail.com> References: <201512191842.tBJIgohI010539@repo.freebsd.org> <CAPyFy2BfFxfm1Yas06v%2ByZUtbTA5QWf1wzc0nF8ZjWyZTTaeVQ@mail.gmail.com> <610A02A5-1399-4A6C-993C-CDCC9DC8502A@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 22, 2015 18:48, "NGie Cooper" <yaneurabeya@gmail.com> wrote: > > > > On Dec 22, 2015, at 13:51, Ed Maste <emaste@freebsd.org> wrote: > > > > On 19 December 2015 at 13:42, Alan Cox <alc@freebsd.org> wrote: > >> Author: alc > >> Date: Sat Dec 19 18:42:50 2015 > >> New Revision: 292469 > >> URL: https://svnweb.freebsd.org/changeset/base/292469 > >> > >> Log: > >> Introduce a new mechanism for relocating virtual pages to a new physical > >> address and use this mechanism when: > > > > Universe build is failing on powerpc.powerpc with: > > > > cc1: warnings being treated as errors > > /scratch/tmp/emaste/freebsd/sys/vm/vm_page.c: In function 'vm_page_reclaim_run': > > /scratch/tmp/emaste/freebsd/sys/vm/vm_page.c:2449: warning: comparison > > is always true due to limited range of data type > > *** [vm_page.o] Error code 1 > > +1 > > It=E2=80=99s only with the MPC85XX kernel, which I believe is 32-bit powe= rpc. > > Thanks! > -NGie Correct, this is due to the fact that on this target vm_paddr_t is 64-bit, and trunc_page() macro casts through unsigned long (32 bits). I have a patch that removes all casts for vm macros in PowerPC (PowerPC is the only target that casts for these macros still), in code review right now (only been lightly tested). - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHSQbTAMHsrOPMR_ikk2XBSBPpSpfcEbh607iRpN-TJEREoFDQ>