Date: Fri, 12 Aug 2022 08:25:07 -0400 From: Matteo Riondato <matteo@freebsd.org> To: Maxim Sobolev <sobomax@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 6a70a0c8bfa6 - main - Document implicit dependencies of the mlx5(4) & friends. Message-ID: <20220812122507.6ojv2jtul5jcewch@host-ubertino-mac-24f5a28a9493.wired.10net.amherst.edu> In-Reply-To: <202208112333.27BNXe7R038996@gitrepo.freebsd.org> References: <202208112333.27BNXe7R038996@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--vgoqmxzbptosqwmc Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2022-08-11 at 19:33 EDT, Maxim Sobolev <sobomax@FreeBSD.org> wrote: >The branch main has been updated by sobomax: > >URL: https://cgit.FreeBSD.org/src/commit/?id=3D6a70a0c8bfa6fe8a2739527e5c8= 22aec985e83e9 > >commit 6a70a0c8bfa6fe8a2739527e5c822aec985e83e9 >Author: Maxim Sobolev <sobomax@FreeBSD.org> >AuthorDate: 2022-08-11 23:28:27 +0000 >Commit: Maxim Sobolev <sobomax@FreeBSD.org> >CommitDate: 2022-08-11 23:33:09 +0000 > > Document implicit dependencies of the mlx5(4) & friends. > > MFC after: 2 weeks >--- > sys/amd64/conf/GENERIC | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/sys/amd64/conf/GENERIC b/sys/amd64/conf/GENERIC >index 53c6043a0146..9178abba36cc 100644 >--- a/sys/amd64/conf/GENERIC >+++ b/sys/amd64/conf/GENERIC >@@ -260,7 +260,8 @@ device le # AMD Am7900 LANCE and=20 >Am79C9xx PCnet > device ti # Alteon Networks Tigon I/II gigabit Ethernet > > # Nvidia/Mellanox Connect-X 4 and later, Ethernet only >-# mlx5ib requires ibcore infra and is not included by default >+# o requires COMPAT_LINUXKPI and xz(4) >+# o mlx5ib requires ibcore infra and is not included by default Hi Maxim, May I suggest editing the above line to "mlx5ib requires ibcore infra,=20 thus it is not included here" (replacing "and" with "thus" being the=20 important part). The mlx5en(4) page, in SYNOPSIS, lists also option RATELIMIT, option=20 KERN_TLS, and device firmware. Are these needed? I imagine that "device=20 firmware" certainly is (thus should perhaps be listed in the comment=20 above), but what about the options? > device mlx5 # Base driver > device mlxfw # Firmware update > device mlx5en # Ethernet driver Thanks, Matteo --vgoqmxzbptosqwmc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAABCgAxFiEEa9uKZL0hP4E8Nl5vGwL9SVQlVQEFAmL2Rp0TGGhrcHM6Ly9w Z3AubWl0LmVkdQAKCRAbAv1JVCVVAfvBEAC+TMsQhc/MmcTGL3EFY+LMtI7jbp9I PH0za/TEsU1XDtY9d249nY/waQgj5GwROwVvLNNETEhzrOv6kM2LeLZkaaJmj+nZ D65CgL0sX4wRRojbGehOzXARyhG0IMAvmFyQdozFk6VrDEqlSu2RJhOeh1dIsBx2 6AvUqydsvIRl7MI93MEZ5oeeG2OveHFDyij8r7fB7B4e/rqIBtIYCSPAJ9Q79tUl Iu5WJdH9C5nVb056YEoeRlj2oD4rxriKvXMVsUr7zAx3PaGATAqCI0K2Fbh2WrRn QD3bhLpRhfCf+2zHR5MO461RyLHZCnr+NCVN1VaH+TaWcIk4EdTAPVwfivbFIGSr YwRYxKXu2dfupxZqHKCmUcte1m7vQ5VAP3++moUaM1R9yLGpFjTf+HX/tgho/Ww5 Yh0fWhm/9EWLy+0Ok+s7aEhXULFs/YYQCZLiyzlu+Vz8AFgAJxfZS78rXIgkD9st Mkq956RxUMxbkDjzBPVM2uH5zOBIBrqj9vSK9wUZ1pdEb52RV7PzqrLOZmXYxRPg ISdvy0+afPd+xDHSCGwlUK9FU1W12RNuNAaOuL3GNwUjmsADCZPU8qjLgLk2KNhu WhNO9eRtlRMUGTLMVimL1u1L7jhrZ6BYZVOJ69+iO2gNrSQgePxKFzFsu9eqtu03 XJ1KWdepAVrVTQ== =UK8D -----END PGP SIGNATURE----- --vgoqmxzbptosqwmc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220812122507.6ojv2jtul5jcewch>