Date: Sat, 18 Aug 2001 22:32:04 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Jon Parise <jon@csh.rit.edu> Cc: Kris Kennaway <kris@obsecurity.org>, audit@FreeBSD.org Subject: Re: Checking issetugid() with getenv() in libraries Message-ID: <20010818223204.A79607@xor.obsecurity.org> In-Reply-To: <20010819012248.B25899@csh.rit.edu>; from jon@csh.rit.edu on Sun, Aug 19, 2001 at 01:22:49AM -0400 References: <20010818221258.A79194@xor.obsecurity.org> <20010819012248.B25899@csh.rit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--AqsLC8rIMeq19msA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Aug 19, 2001 at 01:22:49AM -0400, Jon Parise wrote:
> On Sat, Aug 18, 2001 at 10:12:58PM -0700, Kris Kennaway wrote:
>=20
> > Index: libss/pager.c
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > RCS file: /mnt/ncvs/src/lib/libss/pager.c,v
> > retrieving revision 1.5
> > diff -u -r1.5 pager.c
> > --- libss/pager.c 2000/12/09 09:35:33 1.5
> > +++ libss/pager.c 2001/08/19 04:56:47
> > @@ -81,7 +81,7 @@
> > sigsetmask(mask);
> > }
> > if (_ss_pager_name =3D=3D (char *)NULL) {
> > - if ((_ss_pager_name =3D getenv("PAGER")) =3D=3D (char *)NULL)
> > + if (issetugid() !=3D0 || (_ss_pager_name =3D getenv("PAGER")) =3D=3D=
(char *)NULL)
> ^^^
> Missing a space before the zero (i.e. issetugid() !=3D 0).
Oops, thanks.
Kris
--AqsLC8rIMeq19msA
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org
iD8DBQE7f09TWry0BWjoQKURAtxcAKDXyPdgCiX4B88MVZZQygVIIqKMtQCeKzW3
3ZOSj0xL4KMHTiN1DX+EjqY=
=WrXG
-----END PGP SIGNATURE-----
--AqsLC8rIMeq19msA--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010818223204.A79607>