Date: Tue, 06 Dec 2005 22:08:49 +0000 From: Florent Thoumie <flz@FreeBSD.org> To: obrien@FreeBSD.org Cc: cvs-ports@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: ports/shells/bash Makefile Message-ID: <1133906929.679.2.camel@cream.xbsd.org> In-Reply-To: <20051206201757.GA3970@dragon.NUXI.org> References: <200511301510.jAUFACmr038837@repoman.freebsd.org> <20051130161657.GA65549@FreeBSD.org> <1133371126.1219.23.camel@cream.xbsd.org> <20051130183717.GA71920@xor.obsecurity.org> <1133380999.1219.30.camel@cream.xbsd.org> <20051205093626.GA68544@dragon.NUXI.org> <1133782867.879.3.camel@cream.xbsd.org> <20051206201757.GA3970@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Le Mardi 06 décembre 2005 à 12:17 -0800, David O'Brien a écrit : > On Mon, Dec 05, 2005 at 11:41:07AM +0000, Florent Thoumie wrote: > > Le Lundi 05 décembre 2005 à 01:36 -0800, David O'Brien a écrit : > > > On Wed, Nov 30, 2005 at 08:03:19PM +0000, Florent Thoumie wrote: > > > > Le Mercredi 30 novembre 2005 à 13:37 -0500, Kris Kennaway a écrit : > > > > > Don't commit bogus changes, and > > > > > > > > > > > 2) shells/bash2 has the same exact construction. > > > > > > > > > > fix bogus changes when you encounter them. > > > > > > > > I'll send a PR with s/WANT/WITH/ later and will commit the fix > > > > in two weeks with maintainer timeout. > > > > > > *sigh* why all the overhead? Since you're already in the middle of this > > > issue, please make it right for our users and just commit the fixed > > > version now. > > > > I'm fine with people fixing my mistakes, but that's not > > something I would assume for every maintainer, so I just wanted > > to ask in the first place. > > I guess I have the opposite thinking :-) - once you start commiting a > change you're responsible for seeing it thru into proper shape if the > first commit had issues. That's right (for shell/bash in that case), but I wouldn't touch shell/bash2 without your approval or a two weeks period of inactivity (after notification). Anyway, that's fixed now, let's go fixing something else :-) -- Florent Thoumie flz@FreeBSD.org FreeBSD committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1133906929.679.2.camel>