Date: Wed, 13 Oct 2010 22:17:10 +0100 From: Rui Paulo <rpaulo@freebsd.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r213779 - head/sys/dev/sound/pci Message-ID: <C8F8A6C0-CBFB-4874-9D71-F311D64EA0B3@freebsd.org> In-Reply-To: <201010131703.21145.jkim@FreeBSD.org> References: <201010131439.o9DEdssc090571@svn.freebsd.org> <201010131546.10130.jkim@FreeBSD.org> <F670176F-BA62-44ED-9CC5-06C36A191258@freebsd.org> <201010131703.21145.jkim@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On 13 Oct 2010, at 22:03, Jung-uk Kim wrote: > On Wednesday 13 October 2010 04:30 pm, you wrote: >> I read the PR and the mailing list posts, but I don't see what >> problem does "case SPICDS_TYPE_AK4381 || SPICDS_TYPE_AK4396:" fix. > > A similar bug for right channel was fixed by netchild@ in r188480: > > http://svn.freebsd.org/viewvc/base/head/sys/dev/sound/pci/spicds.c?view=log > > but he missed the left channel, which caused volume differences > between the two channels. > > "In FreeBSD 7.2 it worked just like a charm but after upgrading to 8.0 > the left stereo channel is only half as loud as the right one. It can > be reproduced with either speakers and headphones. I tracked it down > to a change in revision 188480 of spicds.c, the change "fix: stupid > bug with volume control for AK4396" breaks volume control for me. > > http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-December/010553html > > Carl Johan Gustavsson submitted a correct patch: > > http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-December/010558html > > ariff@ said he would take it but I guess he never did: > > http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-December/010575html Oh, I read your previous email backwards. This explains it, thanks. Guess we can close the PR now. Regards, -- Rui Paulohelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C8F8A6C0-CBFB-4874-9D71-F311D64EA0B3>