Date: Thu, 11 Jul 2019 04:50:03 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Randall Stewart <rrs@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r349907 - head/sys/netinet/tcp_stacks Message-ID: <201907111150.x6BBo3YA009396@slippy.cwsent.com> In-Reply-To: Message from Randall Stewart <rrs@FreeBSD.org> of "Thu, 11 Jul 2019 04:38:33 -0000." <201907110438.x6B4cXX1054795@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <201907110438.x6B4cXX1054795@repo.freebsd.org>, Randall Stewart writ es: > Author: rrs > Date: Thu Jul 11 04:38:33 2019 > New Revision: 349907 > URL: https://svnweb.freebsd.org/changeset/base/349907 > > Log: > Update copyright per JBH's suggestions.. thanks. > > Modified: > head/sys/netinet/tcp_stacks/rack.c > > Modified: head/sys/netinet/tcp_stacks/rack.c > ============================================================================= > = > --- head/sys/netinet/tcp_stacks/rack.c Thu Jul 11 03:29:25 2019 > (r349906) > +++ head/sys/netinet/tcp_stacks/rack.c Thu Jul 11 04:38:33 2019 > (r349907) > @@ -1,5 +1,5 @@ > /*- > - * Copyright (c) 2016 > + * Copyright (c) 2016-2019 > * Netflix Inc. All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > @@ -8537,10 +8537,10 @@ out: > * retransmit. In persist state, just set snd_max. > */ > if (error == 0) { > -/* if (TCPS_HAVEESTABLISHED(tp->t_state) && > + if (TCPS_HAVEESTABLISHED(tp->t_state) && > (tp->t_flags & TF_SACK_PERMIT) && > tp->rcv_numsacks > 0) > - tcp_clean_dsack_blocks(tp);*/ > + tcp_clean_dsack_blocks(tp); > if (len == 0) > counter_u64_add(rack_out_size[TCP_MSS_ACCT_SNDACK], 1); > else if (len == 1) { > This commit updates more than just the copyright. Were the other changes intended? If yes, a) Removing the */ at the other end of the commented block is also needed. b) The commit log is incorrect. Let's revert this and try again. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201907111150.x6BBo3YA009396>