Date: Mon, 6 Mar 2023 20:55:01 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Koichiro Iwao <meta@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d69b20995dec - main - security/softether5: add DEBUG option Message-ID: <20230306195501.ithqt45oxm2z2mgn@aching.in.mat.cc> In-Reply-To: <20230306195254.n3gxqbchj5voyypw@aching.in.mat.cc> References: <202303060432.3264Wbtc041269@gitrepo.freebsd.org> <ZAWLnDz5cb4vIR/j@FreeBSD.org> <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp> <20230306195254.n3gxqbchj5voyypw@aching.in.mat.cc>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Mon, Mar 06, 2023 at 08:52:54PM +0100, Mathieu Arnold wrote:
> On Mon, Mar 06, 2023 at 11:25:06PM +0900, Koichiro Iwao wrote:
> > On Mon, Mar 06, 2023 at 06:43:40AM +0000, Alexey Dokuchaev wrote:
> > > On Mon, Mar 06, 2023 at 04:32:37AM +0000, Koichiro Iwao wrote:
> > > > commit d69b20995dec38f96ef28522bc6156a7d5b80fff
> > > >
> > > > security/softether5: add DEBUG option
> > > >
> > > > [...]
> > > > +.include <bsd.port.options.mk>
> > > > +
> > > > +# CMAKE_BUILD_TYPE is automatically set by Mk/Uses/cmake.mk
> > > > +# just set WITH_DEBUG=yes, CMAKE_ARGS+=-DCMAKE_BUILD_TYPE=Debug takes no effect.
> > > > +.if ${PORT_OPTIONS:MDEBUG}
> > > > +WITH_DEBUG= yes
> > >
> > > We do not expose this via options. To build debug package, just
> > > "make -DWITH_DEBUG", don't ask users to fiddle with options.
> > >
> > > ./danfe
> >
> > Really? What's the difference exposing ports vs not?
>
> WITH_DEBUG is a global user facing knob, it must never be activated via
> options.
Sorry, bad wording, it must never be set in any Makefile, wether
options, flavor, or whatever. It is not a port setting, that one sets
in a Makefile, it is a user setting that one sets in make.conf.
--
Mathieu Arnold
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmQGRRVfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1
NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d
Qb50swv9Er+cO3XECHsXHPLE9zpULdaToENyZwyQz2OODIQ47jysIN1wqx0UtRE1
3tFNhPkiqXDPvEFp4Q3DMikhX/eaMZ6QUYMULm+P/z/OJzwdsk9JsOicY3dyfNCF
xeaa7IFudHc5TOHIxwZfWZlRzkutgVp9vsHGtCy4NxUtneMSABl43aXX3dMreSS5
EKgpS2bLxiFjh6qgpgE6f/CuTK2GPYOEuKQhH9m5fQcnvEitslYrOhMbRXllyO9J
i6N17R/mPYyctb3E7rSwxKCZVI/7naOqMjxwEgBaFNN2VodQSA0dJ7s/K0PW0Hwn
tZpFmoM1GZKTTPAUmRWfv0ObYj4RlAV16G5sqM4x9C5EKmr4THSY1DUAT3Tjy/gN
AXnD1aCzwZjYL4Fl8XxIXjnj59p/hsFDtBxuGm1WwkPoAUMVWvyM+vB5Qm0M4kXq
xKk+n9PAYE9NNK6BstRp8oZjdn01ArUPwCax5NmrRiVqsqjT5D4fZTwsk3JJg9sq
r1oWt7LV
=SiOE
-----END PGP SIGNATURE-----
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230306195501.ithqt45oxm2z2mgn>