Date: Wed, 24 Jan 2018 11:47:16 -0700 From: Warner Losh <imp@bsdimp.com> To: "Conrad E. Meyer" <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev/... Message-ID: <CANCZdfoTaTCHp%2B9YjDXw5tq4-owDCAJDKbXoR%2BUPhC-kkV=uoA@mail.gmail.com> In-Reply-To: <CAG6CVpX4wO4mgiG_j7hxPKumu6BmaNwzGb9pAVPv_gc%2B0HYRug@mail.gmail.com> References: <201801211542.w0LFgbsp005980@repo.freebsd.org> <CAG6CVpXxuFyHS11rF=NF6bSSkC2=xnDh=WnbK-aWp4sOomrZ7w@mail.gmail.com> <51ff8aef-5660-7857-e4d5-12cdc77bc071@FreeBSD.org> <20180124182548.X1063@besplex.bde.org> <CANCZdfpL7t_J6xXi8w%2BwtxE%2B4x8EA0AzqzQKno=dUKaJ_NXFrw@mail.gmail.com> <CAG6CVpWv32FjZggRCM3JNWCsMDOSXbVzQfP-dh73fei6Hqr5Mw@mail.gmail.com> <1516817048.42536.182.camel@freebsd.org> <CAG6CVpUpVLe5f=As44TOyePDTy-7LaTKA=rCkk-NjZvZkA5nQg@mail.gmail.com> <CANCZdfqZ5ZiMceh7NZ-YpbgsTW6gqwcxVun0XM_bY2%2BFpustKQ@mail.gmail.com> <CAG6CVpX4wO4mgiG_j7hxPKumu6BmaNwzGb9pAVPv_gc%2B0HYRug@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 24, 2018 11:33 AM, "Conrad Meyer" <cem@freebsd.org> wrote: Bruce didn't get this wrong, you've just misread his (style / opinion) complaint as an actual bug (which is kind of the whole reason why it's hard to treat his complaints seriously): > size_t happens to have the same representation as u_long on all supported arches So yes, the check works on i386. I confused off_t and size_t, so much of what I said turns out not to be relevant. I'd be fine with just fixing the style issue, renaming WOULD_OVERFLOW to malloc_would_overrflow and using that for most of the NO_WAIT cases as a precheck.... Warner Warner Best, Conrad On Wed, Jan 24, 2018 at 10:28 AM, Warner Losh <imp@bsdimp.com> wrote: > Does mallocarray(10 ,1Gb) panic on i386? It does not. It should. > > Warner > > On Jan 24, 2018 11:20 AM, "Conrad Meyer" <cem@freebsd.org> wrote: >> >> Please point out what in Bruce's rant is actually relevant. Again, I >> usually start reading them and get sidetracked in things that are >> opinions stated as fact, or outright incorrect. At which point, I >> give up on them. >> >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoTaTCHp%2B9YjDXw5tq4-owDCAJDKbXoR%2BUPhC-kkV=uoA>