Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Aug 1995 18:11:13 -0700
From:      David Greenman <davidg@Root.COM>
To:        terry@cs.weber.edu (Terry Lambert)
Cc:        hackers@freebsd.org
Subject:   Re: sys/malloc.h 
Message-ID:  <199508250111.SAA00647@corbin.Root.COM>
In-Reply-To: Your message of "Thu, 24 Aug 95 16:36:57 MDT." <9508242236.AA09192@cs.weber.edu> 

next in thread | previous in thread | raw e-mail | index | archive | help
>Some kernel memory allocation issues:
>
>1)	Does it seem to anyone else as if the statistic's gathering
>	macros on the MALLOC/FREE are rather bizarre?

   I'd say that was a matter of opinion, but they make sense to me.

>2)	Has anyone else noticed the mixing of FREE/free on cn_pnbuf
>	elements of nameidata structures?  Doesn't this seem broken,
>	considering the use of MALLOC in the non-'HASBUF' case for
>	allocation in all cases in vfs_lookup.c?  Won't this fail
>	for the case of a kernel without either KMEMSTATS or
>	DIAGNOSTIC defined?

   The KMEMSTATS #ifdefs are bogus and should be removed. I had removed them
once in my local sources but the changes got lost. We always gather malloc
stats in FreeBSD - the information is just too important to be without.

-DG



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508250111.SAA00647>