Date: Wed, 15 Oct 2014 17:05:34 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, "George V. Neville-Neil" <gnn@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, Olivier =?utf-8?Q?Cochard-Labb?= =?utf-8?Q?=C3=A9?= <olivier@cochard.me>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys Message-ID: <86siipxtj5.fsf@nine.des.no> In-Reply-To: <CAPyFy2Cde8r0sRBc2X9fBPqLnb1RCm%2B0abYLpV_%2BW0McRRctkg@mail.gmail.com> (Ed Maste's message of "Wed, 15 Oct 2014 09:10:10 -0400") References: <201410101926.s9AJQRY1049602@svn.freebsd.org> <CA%2Bq%2BTcpt0zEbgu_LndZb4dzh=xykHvppeykuiG6P9cTJgDGeWw@mail.gmail.com> <20141015030455.GC73266@FreeBSD.org> <CAPyFy2CDSwLkTtPFj70tw2iuDam3rS4yFNri=pX0w7_58UYMoA@mail.gmail.com> <86wq81y9fz.fsf@nine.des.no> <CAPyFy2Cde8r0sRBc2X9fBPqLnb1RCm%2B0abYLpV_%2BW0McRRctkg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ed Maste <emaste@freebsd.org> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > That's my fault, and I'm going to change it, because it's illogical. > > The function works on aligned arrays of int32s and should take a count, > > not a size. I just didn't want to delay the patch even further. > The fact that it works only on aligned 32-bit ints is a detail of this > implementation and not a requirement of murmur3 though. Absolutely. This implementation was tuned specifically for pf's use and therefore only works on aligned arrays. It is a pared-down version of a more complete implementation I wrote for cryb.to (still a WIP). DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86siipxtj5.fsf>