Date: Thu, 23 May 2024 12:34:03 -0600 From: Warner Losh <imp@bsdimp.com> To: Brooks Davis <brooks@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a5f03413aade - main - ci: Redirect output for builds. Message-ID: <CANCZdfqiHXLOuH2AHXcVYmNeedb2YukJdPg8RZ9%2Bp__zZzcoDQ@mail.gmail.com> In-Reply-To: <Zk-J6aatixxTOmDJ@spindle.one-eyed-alien.net> References: <202405231800.44NI02TZ002201@gitrepo.freebsd.org> <Zk-J6aatixxTOmDJ@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, May 23, 2024 at 12:24 PM Brooks Davis <brooks@freebsd.org> wrote: > On Thu, May 23, 2024 at 06:00:02PM +0000, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=a5f03413aade8f69cf954162151da043d34dd1f5 > > > > commit a5f03413aade8f69cf954162151da043d34dd1f5 > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2024-05-23 17:37:01 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2024-05-23 17:59:40 +0000 > > > > ci: Redirect output for builds. > > > > This target is far too noisy to be at all useful. Save the output ala > > make universe in _. files. Also report where to find errors. > > If this target is intended to be run in a variety CI system then this > won't work in practice as many have no way to preserve the contents of > the files (jenkins does with sufficient configuration, but then you > have to expose it to the world which is a security problem given its > vulnerability history.) > This is a developer tool to run CI before committing. It's not going to run in Jenkins. If we want that, it will have to be a different target. It's way too verbose otherwise to be a useful developer tool... so verbose as to not be at all useful. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 23, 2024 at 12:24 PM Brooks Davis <<a href="mailto:brooks@freebsd.org">brooks@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, May 23, 2024 at 06:00:02PM +0000, Warner Losh wrote:<br> > The branch main has been updated by imp:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=a5f03413aade8f69cf954162151da043d34dd1f5" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=a5f03413aade8f69cf954162151da043d34dd1f5</a><br>; > <br> > commit a5f03413aade8f69cf954162151da043d34dd1f5<br> > Author: Warner Losh <imp@FreeBSD.org><br> > AuthorDate: 2024-05-23 17:37:01 +0000<br> > Commit: Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2024-05-23 17:59:40 +0000<br> > <br> > ci: Redirect output for builds.<br> > <br> > This target is far too noisy to be at all useful. Save the output ala<br> > make universe in _. files. Also report where to find errors.<br> <br> If this target is intended to be run in a variety CI system then this<br> won't work in practice as many have no way to preserve the contents of<br> the files (jenkins does with sufficient configuration, but then you<br> have to expose it to the world which is a security problem given its<br> vulnerability history.)<br></blockquote><div><br></div><div>This is a developer tool to run CI before committing. It's not going to run in Jenkins. If we want that, it will have to be a different target. It's way too verbose otherwise to be a useful developer tool... so verbose as to not be at all useful.</div><div><br></div><div>Warner </div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqiHXLOuH2AHXcVYmNeedb2YukJdPg8RZ9%2Bp__zZzcoDQ>