Date: Thu, 22 Feb 2024 12:32:44 +0300 From: Max Brazhnikov <makc@freebsd.org> To: Nuno Teixeira <eduardo@freebsd.org> Cc: Po-Chuan Hsieh <sunpoet@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 48437516330b - main - www/nghttp2: Remove unnecessary substitution Message-ID: <CAJie3yrwPM5QFj5=c1%2BCR3vQgdfgU8a2d7eJOt%2BS1CdVHMWnDw@mail.gmail.com> In-Reply-To: <CAFDf7UJ6m%2Bnu02o4JsJVhCH%2B7nARGm%2BUbaUPENLSCtbvAAS3dQ@mail.gmail.com> References: <202402211520.41LFKHJO027649@gitrepo.freebsd.org> <CAFDf7UJ6m%2Bnu02o4JsJVhCH%2B7nARGm%2BUbaUPENLSCtbvAAS3dQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 22 Feb 2024 at 11:01, Nuno Teixeira <eduardo@freebsd.org> wrote: > > Hello, > > What's going on? > > -DISTVERSION= 1.59.0 > +PORTVERSION= 1.59.0 > > Should Porter's Handbook be fixed? Or veteran committers should update their knowledge :) Less jokingly, the problem with DISTVERSION/PORTVERSION is that the Porters's Handbook and ports framework are out of sync. Somebody has decided that DISTVERSION is higher than PORTVERION (makes sense for me, if you want my opinion) and has commited update to the handbook. However, the framework has not been changed, it checks for PORTVERION first, while DISTVERSION is derived from PORTVERION. If we want to switch to DISTVERSION and deprecate PORTVERSION, we should update the framework and docs and CHANGES and notify people before upcoming change and after. This applies to other changes in the ports framework. Cheers, Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJie3yrwPM5QFj5=c1%2BCR3vQgdfgU8a2d7eJOt%2BS1CdVHMWnDw>