Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 17 Jan 2009 16:28:27 +0100
From:      =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To:        Roman Divacky <rdivacky@freebsd.org>
Cc:        current@freebsd.org
Subject:   Re: [PATCH]: set C dialect when compiling world
Message-ID:  <8663keymsk.fsf@ds4.des.no>
In-Reply-To: <20090113221127.GA31906@freebsd.org> (Roman Divacky's message of "Tue, 13 Jan 2009 23:11:27 %2B0100")
References:  <20090113215520.GA29635@freebsd.org> <20090113221127.GA31906@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Roman Divacky <rdivacky@freebsd.org> writes:

> On Tue, Jan 13, 2009 at 10:55:20PM +0100, Roman Divacky wrote:
>> hi
>>=20
>> in my effort to make world compile in gnu99 mode I'd like this
>> patch to be commited:
>>=20
>> Index: bsd.sys.mk
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v
>> retrieving revision 1.47
>> diff -u -r1.47 bsd.sys.mk
>> --- bsd.sys.mk	23 Jul 2008 06:14:21 -0000	1.47
>> +++ bsd.sys.mk	13 Jan 2009 21:36:04 -0000
>> @@ -8,8 +8,11 @@
>>=20=20
>>  # for GCC:  http://gcc.gnu.org/onlinedocs/gcc-3.0.4/gcc_3.html#IDX143
>>=20=20
>> -.if !defined(NO_WARNS) && ${CC} !=3D "icc"
>> -. if defined(CSTD)
>> +# the default is gnu89 for now
>> +. if !defined(CSTD)
>> +CSTD		=3D gnu89
>> +. endif
>> +
>
> CSTD	+=3D gnu89
>
> of course :)

Why "of course"?  Can you explain the expected semantics when CSTD
contains more than one word?

>> +. if !defined(CSTD)
>> +CSTD		=3D gnu89
>> +. endif

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8663keymsk.fsf>