Date: Fri, 13 Nov 2020 16:58:03 -0800 From: Ravi Pokala <rpokala@freebsd.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Rebecca Cran <bcran@FreeBSD.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r367651 - head/usr.sbin/bhyve Message-ID: <26286559-64EA-4E5B-B5E6-3BD2C1C949FF@panasas.com> In-Reply-To: <C86489F8-4811-4BCA-B9E7-B4B37A82C7A5@freebsd.org> References: <202011131947.0ADJlGbr064616@repo.freebsd.org> <328D3129-4682-491B-A28F-D6739E52ABE8@panasas.com> <C86489F8-4811-4BCA-B9E7-B4B37A82C7A5@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----Original Message-----
From: <owner-src-committers@freebsd.org> on behalf of Jessica Clarke <jrtc27@freebsd.org>
Date: 2020-11-13, Friday at 16:53
To: Ravi Pokala <rpokala@freebsd.org>
Cc: Rebecca Cran <bcran@FreeBSD.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Subject: Re: svn commit: r367651 - head/usr.sbin/bhyve
On 14 Nov 2020, at 00:47, Ravi Pokala <rpokala@freebsd.org> wrote:
>
>> +#define FIRMWARE_RELEASE_DATE "11/10/2020"
>
> Might I suggest "2020-11-10", as sorting, logic, ${DEITY}, and ISO-8601 demand? ;-)
Alas that is a "feature" of the specification:
String number of the BIOS release date. The date string, if supplied,
is in either mm/dd/yy or mm/dd/yyyy format. If the year portion of the
string is two digits, the year is assumed to be 19yy.
NOTE: The mm/dd/yyyy format is required for SMBIOS version 2.3 and
later.
(SMBIOS Specification version 3.4.0c)
<sigh>
Yeah, it occurred to me that it might be something like that shortly after I hit "send". :-p
It might be worth putting a comment in so people don't accidentally
change it to the wrong thing in future though, given it's currently
ambiguous otherwise.
That would be appreciated.
Thanks,
Ravi (rpokala@)
Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?26286559-64EA-4E5B-B5E6-3BD2C1C949FF>