Date: Tue, 23 Mar 2021 20:10:19 +0100 From: Jochen Neumeister <joneum@FreeBSD.org> To: Piotr Kubaj <pkubaj@anongoth.pl> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r569017 - head/databases/mysql57-server Message-ID: <501ca173-346a-11a1-581f-daa0b7e701f6@FreeBSD.org> In-Reply-To: <YFo6wvpNciSSK6Dv@KGPE-D16> References: <202103231049.12NAnNUa027511@repo.freebsd.org> <650caf6e-5ab6-ec52-7cde-c77757a5d019@FreeBSD.org> <YFo6wvpNciSSK6Dv@KGPE-D16>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 23.03.21 um 20:00 schrieb Piotr Kubaj:
> Hello,
>
> as Chris already mentioned, this is under a blanket approval.
>
> I think we can all agree that it's a simple and trivial patch.
> I also think that it's simple enough that it would be hard to actually improve it (e.g. there are no helpers, so you wouldn't be able to suggest setting e.g. LLD_UNSAFE_powerpc).
> It also doesn't break anything, because there is .if ${ARCH}.
And still, a message would be nice if they just keep changing other
people's ports.
>
> On 21-03-23 18:14:48, Jochen Neumeister wrote:
>> It would be nice if you at least write an eMail before that you want to
>> change something on someone else's port .....
>>
>> Jochen
>>
>>
>>
>> Am 23.03.21 um 11:49 schrieb Piotr Kubaj:
>>> Author: pkubaj
>>> Date: Tue Mar 23 10:49:23 2021
>>> New Revision: 569017
>>> URL: https://svnweb.freebsd.org/changeset/ports/569017
>>>
>>> Log:
>>> databases/mysql57-server: don't use LLD for linking on powerpc
>>>
>>> LLD currently fails:
>>> ld: error: relocation refers to a discarded section: .rodata._ZN5boost6detail8function15functor_managerINS_9algorithm6detail13token_finderFINS4_10is_any_ofFIcEEEEE7managerERKNS1_15function_bufferERSA_NS1_30functor_manager_operation_typeEN4mpl_5bool_ILb0EEE
>>> >>> defined in ../../archive_output_directory/libmysqlpump_lib.a(object_filter.cc.o)
>>> >>> referenced by object_filter.cc
>>> >>> object_filter.cc.o:(.got2+0x108) in archive ../../archive_output_directory/libmysqlpump_lib.a
>>>
>>> ld: error: relocation refers to a discarded section: .rodata._ZN5boost6detail8function15functor_managerINS_9algorithm6detail13token_finderFINS4_10is_any_ofFIcEEEEE7managerERKNS1_15function_bufferERSA_NS1_30functor_manager_operation_typeEN4mpl_5bool_ILb0EEE
>>> >>> defined in ../../archive_output_directory/libmysqlpump_lib.a(sql_formatter.cc.o)
>>> >>> referenced by sql_formatter.cc
>>> >>> sql_formatter.cc.o:(.got2+0x130) in archive ../../archive_output_directory/libmysqlpump_lib.a
>>>
>>> ld: error: relocation refers to a discarded section: .rodata._ZN5boost6detail8function15functor_managerINS_9algorithm6detail13token_finderFINS4_10is_any_ofFIcEEEEE7managerERKNS1_15function_bufferERSA_NS1_30functor_manager_operation_typeEN4mpl_5bool_ILb0EEE
>>> >>> defined in ../../archive_output_directory/libmysqlpump_lib.a(table.cc.o)
>>> >>> referenced by table.cc
>>> >>> table.cc.o:(.got2+0x50) in archive ../../archive_output_directory/libmysqlpump_lib.a
>>> clang++: error: linker command failed with exit code 1 (use -v to see invocation)
>>>
>>> Modified:
>>> head/databases/mysql57-server/Makefile
>>>
>>> Modified: head/databases/mysql57-server/Makefile
>>> ==============================================================================
>>> --- head/databases/mysql57-server/Makefile Tue Mar 23 10:47:46 2021 (r569016)
>>> +++ head/databases/mysql57-server/Makefile Tue Mar 23 10:49:23 2021 (r569017)
>>> @@ -174,6 +174,10 @@ CC= ${LOCALBASE}/bin/clang${LLVM_DEFAULT}
>>> CXX= ${LOCALBASE}/bin/clang++${LLVM_DEFAULT}
>>> .endif
>>>
>>> +.if ${ARCH} == powerpc
>>> +LLD_UNSAFE= yes
>>> +.endif
>>> +
>>> post-extract:
>>> @${RM} -rv ${WRKSRC}/sql/sql_hints.yy.cc ${WRKSRC}/sql/sql_hints.yy.h
>>>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?501ca173-346a-11a1-581f-daa0b7e701f6>