Date: Fri, 1 Aug 2014 18:36:41 +0000 (UTC) From: Peter Grehan <grehan@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r269391 - head/sys/netinet Message-ID: <201408011836.s71IafGI040646@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: grehan Date: Fri Aug 1 18:36:40 2014 New Revision: 269391 URL: http://svnweb.freebsd.org/changeset/base/269391 Log: Fix byte ordering in default RSS key. The rss_key[] array in netinet/in_rss.c has the bytes in incorrect order. This results in the RSS test vectors in the Microsft RSS spec and Intel NIC specs giving incorrect results, and making it difficult to verify correct hash operation when RSS functionality is added to new NICs. CR: https://phabric.freebsd.org/D516 Reviewed by: adrian Modified: head/sys/netinet/in_rss.c Modified: head/sys/netinet/in_rss.c ============================================================================== --- head/sys/netinet/in_rss.c Fri Aug 1 18:24:44 2014 (r269390) +++ head/sys/netinet/in_rss.c Fri Aug 1 18:36:40 2014 (r269391) @@ -153,11 +153,11 @@ SYSCTL_INT(_net_inet_rss, OID_AUTO, base * the Chelsio T5 firmware default key. */ static uint8_t rss_key[RSS_KEYSIZE] = { - 0xbe, 0xac, 0x01, 0xfa, 0x6a, 0x42, 0xb7, 0x3b, - 0x80, 0x30, 0xf2, 0x0c, 0x77, 0xcb, 0x2d, 0xa3, - 0xae, 0x7b, 0x30, 0xb4, 0xd0, 0xca, 0x2b, 0xcb, - 0x43, 0xa3, 0x8f, 0xb0, 0x41, 0x67, 0x25, 0x3d, - 0x25, 0x5b, 0x0e, 0xc2, 0x6d, 0x5a, 0x56, 0xda, + 0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2, + 0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0, + 0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4, + 0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c, + 0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa, }; /*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201408011836.s71IafGI040646>