Date: Mon, 8 Mar 2010 15:03:29 -0500 From: David Horn <dhorn2000@gmail.com> To: Andrew Thompson <thompsa@freebsd.org> Cc: freebsd-net@freebsd.org, d@delphij.net Subject: Re: Why lagg(4) wants ~IFF_DRV_OACTIVE? Message-ID: <25ff90d61003081203w48829572v37709d866eaae165@mail.gmail.com> In-Reply-To: <20100308193246.GB38183@citylink.fud.org.nz> References: <4B954C19.9050606@delphij.net> <20100308193246.GB38183@citylink.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Mar 8, 2010 at 2:32 PM, Andrew Thompson <thompsa@freebsd.org> wrote: > On Mon, Mar 08, 2010 at 11:12:25AM -0800, Xin LI wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Hi, >> >> Maybe this is a stupid question but I really don't understand why a >> interface with IFF_DRV_OACTIVE can't be added to a lagg(4) interface. >> Looking at OpenBSD code, they do this since the day 0. >> >> Could anyone shed some light, why we need to enforce this check? :) > > I think it was just carried over, I dont see any reason to keep it. That's good news. Someone, please review and commit attached patch for sys/net/if_lagg.c. This also fixes my PR: kern/139117. --Thanks! --_Dave Horn [-- Attachment #2 --] Index: if_lagg.c =================================================================== --- if_lagg.c (revision 204877) +++ if_lagg.c (working copy) @@ -484,10 +484,6 @@ if (sc->sc_count >= LAGG_MAX_PORTS) return (ENOSPC); - /* New lagg port has to be in an idle state */ - if (ifp->if_drv_flags & IFF_DRV_OACTIVE) - return (EBUSY); - /* Check if port has already been associated to a lagg */ if (ifp->if_lagg != NULL) return (EBUSY);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?25ff90d61003081203w48829572v37709d866eaae165>