Date: Mon, 8 Mar 2010 15:03:29 -0500 From: David Horn <dhorn2000@gmail.com> To: Andrew Thompson <thompsa@freebsd.org> Cc: freebsd-net@freebsd.org, d@delphij.net Subject: Re: Why lagg(4) wants ~IFF_DRV_OACTIVE? Message-ID: <25ff90d61003081203w48829572v37709d866eaae165@mail.gmail.com> In-Reply-To: <20100308193246.GB38183@citylink.fud.org.nz> References: <4B954C19.9050606@delphij.net> <20100308193246.GB38183@citylink.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
--001636458c900c3d5c04814f8f2a Content-Type: text/plain; charset=ISO-8859-1 On Mon, Mar 8, 2010 at 2:32 PM, Andrew Thompson <thompsa@freebsd.org> wrote: > On Mon, Mar 08, 2010 at 11:12:25AM -0800, Xin LI wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Hi, >> >> Maybe this is a stupid question but I really don't understand why a >> interface with IFF_DRV_OACTIVE can't be added to a lagg(4) interface. >> Looking at OpenBSD code, they do this since the day 0. >> >> Could anyone shed some light, why we need to enforce this check? :) > > I think it was just carried over, I dont see any reason to keep it. That's good news. Someone, please review and commit attached patch for sys/net/if_lagg.c. This also fixes my PR: kern/139117. --Thanks! --_Dave Horn --001636458c900c3d5c04814f8f2a Content-Type: text/plain; charset=US-ASCII; name="lagg_oactive.diff.txt" Content-Disposition: attachment; filename="lagg_oactive.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g6jp6ofj0 SW5kZXg6IGlmX2xhZ2cuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBpZl9sYWdnLmMJKHJldmlzaW9uIDIwNDg3 NykKKysrIGlmX2xhZ2cuYwkod29ya2luZyBjb3B5KQpAQCAtNDg0LDEwICs0ODQsNiBAQAogCWlm IChzYy0+c2NfY291bnQgPj0gTEFHR19NQVhfUE9SVFMpCiAJCXJldHVybiAoRU5PU1BDKTsKIAot CS8qIE5ldyBsYWdnIHBvcnQgaGFzIHRvIGJlIGluIGFuIGlkbGUgc3RhdGUgKi8KLQlpZiAoaWZw LT5pZl9kcnZfZmxhZ3MgJiBJRkZfRFJWX09BQ1RJVkUpCi0JCXJldHVybiAoRUJVU1kpOwotCiAJ LyogQ2hlY2sgaWYgcG9ydCBoYXMgYWxyZWFkeSBiZWVuIGFzc29jaWF0ZWQgdG8gYSBsYWdnICov CiAJaWYgKGlmcC0+aWZfbGFnZyAhPSBOVUxMKQogCQlyZXR1cm4gKEVCVVNZKTsK --001636458c900c3d5c04814f8f2a--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?25ff90d61003081203w48829572v37709d866eaae165>