Date: Thu, 25 Apr 2019 14:56:36 -0400 From: Tycho Nightingale <tychon@freebsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346687 - head/sys/compat/linuxkpi/common/src Message-ID: <57248B07-6950-4AA0-8A92-B1D0C613E3DA@freebsd.org> In-Reply-To: <78fc1980-3436-6155-a3bd-a3e85c6a5001@FreeBSD.org> References: <201904251813.x3PIDut8078016@repo.freebsd.org> <20190425184300.GM12936@kib.kiev.ua> <78fc1980-3436-6155-a3bd-a3e85c6a5001@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 25, 2019, at 2:50 PM, John Baldwin <jhb@FreeBSD.org> wrote: >=20 > On 4/25/19 11:43 AM, Konstantin Belousov wrote: >> On Thu, Apr 25, 2019 at 06:13:56PM +0000, Tycho Nightingale wrote: >>> Author: tychon >>> Date: Thu Apr 25 18:13:55 2019 >>> New Revision: 346687 >>> URL: https://svnweb.freebsd.org/changeset/base/346687 >>>=20 >>> Log: >>> LinuxKPI buildfix for ppc64 after r346645. >>>=20 >>> Proposed by: hselasky >>> Sponsored by: Dell EMC Isilon >>>=20 >>> Modified: >>> head/sys/compat/linuxkpi/common/src/linux_pci.c >>>=20 >>> Modified: head/sys/compat/linuxkpi/common/src/linux_pci.c >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/sys/compat/linuxkpi/common/src/linux_pci.c Thu Apr 25 = 17:28:36 2019 (r346686) >>> +++ head/sys/compat/linuxkpi/common/src/linux_pci.c Thu Apr 25 = 18:13:55 2019 (r346687) >>> @@ -137,9 +137,9 @@ linux_dma_tag_init(struct device *dev, u64 = dma_mask) >>> dma_mask, /* lowaddr */ >>> BUS_SPACE_MAXADDR, /* highaddr */ >>> NULL, NULL, /* filtfunc, filtfuncarg */ >>> - BUS_SPACE_MAXADDR, /* maxsize */ >>> + BUS_SPACE_MAXSIZE, /* maxsize */ >>> 1, /* nsegments */ >>> - BUS_SPACE_MAXADDR, /* maxsegsz */ >>> + BUS_SPACE_MAXSIZE, /* maxsegsz */ >>> 0, /* flags */ >>> NULL, NULL, /* lockfunc, lockfuncarg */ >>> &priv->dmat); >>=20 >> It seems that amd64 BUS_SPACE_MAXSIZE is 4G, I do not know why. >> Either we should fix that, or the following fix is more appropriate. >> i386 and ppc both have PAE-like configs where maxaddr is 64bit but >> maxsize is 32bit. >=20 > I think we should fix amd64's maxsize. That sounds reasonable. Perhaps this was a conservative choice along = with the 4GB DMA boundary which I removed recently. After some testing I can make this change. Tycho=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57248B07-6950-4AA0-8A92-B1D0C613E3DA>