Date: Sun, 27 May 2001 23:30:03 -0700 (PDT) From: Brooks Davis <brooks@one-eyed-alien.net> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/27701: [PATCH] ifconfig: supported media looks bad : wastes space Message-ID: <200105280630.f4S6U3g15497@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/27701; it has been noted by GNATS.
From: Brooks Davis <brooks@one-eyed-alien.net>
To: brooks@one-eyed-alien.net
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/27701: [PATCH] ifconfig: supported media looks bad : wastes space
Date: Sun, 27 May 2001 23:25:04 -0700
--Dxnq1zWXvFF0Q93v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Oops, I just realized that I didn't complete the formatting upgrade in
that patch. The following extra snipit finishes it:
--- ifmedia.c.orig Sun May 27 23:23:16 2001
+++ ifmedia.c Sun May 27 23:22:32 2001
@@ -502,7 +502,7 @@
{
struct ifmedia_description *desc;
struct ifmedia_type_to_subtype *ttos;
- int seen_option =3D 0, i;
+ int i;
=20
/* Find the top-level interface type. */
for (desc =3D ifm_type_descriptions, ttos =3D ifmedia_types_to_subtypes;
@@ -535,7 +535,7 @@
return;
=20
got_subtype:
- printf("%s", desc->ifmt_string);
+ printf("media %s", desc->ifmt_string);
=20
/* Find options. */
for (i =3D 0; ttos->options[i].desc !=3D NULL; i++) {
@@ -544,14 +544,10 @@
for (desc =3D ttos->options[i].desc;
desc->ifmt_string !=3D NULL; desc++) {
if (ifmw & desc->ifmt_word) {
- if (seen_option =3D=3D 0)
- printf(" <");
- printf("%s%s", seen_option++ ? "," : "",
- desc->ifmt_string);
+ printf(" mediaopt %s", desc->ifmt_string);
}
}
}
- printf("%s", seen_option ? ">" : "");
}
=20
/**********************************************************************
--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
--Dxnq1zWXvFF0Q93v
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE7Ee9AXY6L6fI4GtQRAvrwAKCb+ZoVDK+byqYdLfH/Z9Oo9AmiOACfcEpL
eXeSY56RGOWuYaSImQRHcDw=
=mDuq
-----END PGP SIGNATURE-----
--Dxnq1zWXvFF0Q93v--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105280630.f4S6U3g15497>